Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Multiple Wallets in the Staking App #2417

Closed
nutrina opened this issue Apr 23, 2024 · 4 comments · Fixed by gitcoinco/id-staking-v2-app#43 or #2458
Closed

Support for Multiple Wallets in the Staking App #2417

nutrina opened this issue Apr 23, 2024 · 4 comments · Fixed by gitcoinco/id-staking-v2-app#43 or #2458
Assignees

Comments

@nutrina
Copy link
Collaborator

nutrina commented Apr 23, 2024

User Story:

As an end-user,
I want to connect to the staking app using Metamask, WalletConnect, Brave Wallet, and Coinbase Wallet,
so that I can seamlessly stake and unstake GTC from multiple devices.

Acceptance Criteria

GIVEN I am an end-user,
WHEN I navigate to the staking app at http://stake.passport.xyz/,
THEN I should be presented with options to connect using:

  • Metamask (on both desktop and mobile devices)
  • WalletConnect (across all compatible devices)
  • Brave Wallet (on supported devices)
  • Coinbase Wallet (on supported devices)

Product & Design Links:

Tech Details:

  • Switch over to using Web3Modal, offering support for the four above specified wallet providers.

Open Questions:

Notes/Assumptions:

Ensure compatibility and testing across different platforms and devices for each wallet type.

@erichfi erichfi changed the title Add support for multiple wallets in staking app Support for Multiple Wallets in the Staking App Apr 23, 2024
@lucianHymer lucianHymer self-assigned this Apr 24, 2024
@lucianHymer
Copy link
Collaborator

Taking a break from this task.

Right now, you can log in with walletconnect. But switching chains is only sometimes working. And there are some unhandled errors I haven't tracked down yet in (for example sometimes if you manually switch chains in the metamask mobile app connected with walletconnect).

Also, only a handful of testnets are supported by Rainbow wallet mobile, and OP sepolia isn't one of them.

Browser injected wallets seem to work fine still.

@lucianHymer
Copy link
Collaborator

From Erich, report of issue in main branch. Should check this in this branch:

get wagmi error toast and it pops up brave wallet when sign in with ethereum although i didn't select brave

@erichfi
Copy link
Contributor

erichfi commented May 7, 2024

Team decided to move forward with Web3Modal

@lucianHymer
Copy link
Collaborator

Above PR needs to be merged before deployment, but the necessary update has already been done manually in the review env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants