Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Devanagari and Verse Text differs for some verses #59

Open
sarthak-kumar-shailendra opened this issue Oct 31, 2023 · 5 comments 路 May be fixed by #60
Open

[BUG] Devanagari and Verse Text differs for some verses #59

sarthak-kumar-shailendra opened this issue Oct 31, 2023 · 5 comments 路 May be fixed by #60

Comments

@sarthak-kumar-shailendra
Copy link

sarthak-kumar-shailendra commented Oct 31, 2023 •
edited

馃檨 Actual behavior

@samanyougarg In the below ss the line "艣hva艣hur膩n suh峁沬da艣h chaiva senayor ubhayor api" is missing in the Devanagari for verse 26 and is instead there in verse 27

Screenshot 2023-10-31 at 9 16 56 PM Screenshot 2023-10-31 at 9 17 09 PM

It is happening because of the way we have separated the verses/Devanagari (considering 啷むイ1.26啷むイ as the ending)

Similarly issue can be seen for verse 20
and 21
Screenshot 2023-10-31 at 9 15 43 PM

Screenshot 2023-10-31 at 9 15 52 PM

馃檪 Expected behavior

We need to correct the Devanagari in verse.json file (But if we do this then we will also have to modify the audio file in the verse_recitation folder) similar to what https://www.holy-bhagavad-gita.org/chapter/1/verse/20 is doing.

Screenshot 2023-10-31 at 9 31 44 PM

馃敘 Steps to Reproduce the Problem

Go to menitoned chapter and verse page
@sarthak-kumar-shailendra
Copy link
Author

@Gupta-Anubhav12

@Gupta-Anubhav12
Copy link
Member

Thanks for raising this to us, I confirm the bug in accordance with the text presented in the BBT version of Shri Gita,
please let me know if you can raise a PR or I can work on this, once we fix this in JSON we'll have to redeploy the backend as well

@sarthak-kumar-shailendra
Copy link
Author

I will be happy to work on this issue. Will have to check the same for all the verses. Just wanted to know from where exactly we have collected or recorded the audio files. (If I had known the audio source earlier, I would have raised the PR).

@sarthak-kumar-shailendra sarthak-kumar-shailendra linked a pull request Nov 13, 2023 that will close this issue
Open
@Gupta-Anubhav12
Copy link
Member

Hii we've used https://www.bhagavad-gita.org/ for the audio

@sarthak-kumar-shailendra
Copy link
Author

I have edited the same audio files and created new files by trimming or merging. Request you to verify the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

corrected and added devanagari, verse text, word_meanings and audio sarthak-kumar-shailendra/gita
2 participants
@Gupta-Anubhav12 @sarthak-kumar-shailendra