Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] gtm status does not respect -terminal-off #97

Open
devkabiir opened this issue Jun 22, 2019 · 3 comments
Open

[bug] gtm status does not respect -terminal-off #97

devkabiir opened this issue Jun 22, 2019 · 3 comments
Labels

Comments

@devkabiir
Copy link

I'm on windows 10 x64
Following is the output I get regardless of the -terminal-off flag

λ gtm status -terminal-off=false -total-only
1h15m0s
λ gtm status -terminal-off=true -total-only
1h15m0s

However gtm report does respect the -terminal-off flag.

I've also tried these flag variations, all output the same

  1. Not specifying the flag
  2. Using --terminal-off
  3. Using --terminal-off=true/false

Also,

λ gtm -version
v1.3.5

Note: Regarding #50, I have a custom script that execute gtm record -terminal before every command is executed in windows.

@mschenk42 mschenk42 added the bug label Jun 23, 2019
@mschenk42
Copy link
Member

Thanks for the bug report. We will investigate.

@desaroger
Copy link
Contributor

desaroger commented Jun 23, 2019

I downloaded and builded from source some hours ago, and I just checked and for me gtm status works as expected. I also can write the flags in any form and always works:

  • -terminal-off
  • -terminal-off=true
  • --terminal-off
  • --terminal-off=true

Testing in Ubuntu 16.04. So maybe is something windows-related.

You tried simply -terminal-off (only one dash)? it's not in the things you said you tried, and I think it's the way that the command help shows.

Also, as maybe you have (or going to have) the source code and compiling from there soon, you can log what the command is receiving, i.e. the raw args in string form, and try to check what is going on. Also running the tests would be a good idea. I doubt something windows-related will be shown in the tests, but it's worth trying.

@devkabiir
Copy link
Author

You tried simply -terminal-off (only one dash)? it's not in the things you said you tried, and I think it's the way that the command help shows.

Yes I did, and to make sure I tried again

  • With flag
 gtm status -terminal-off -total-only
4h27m0s
  • Without flag
 gtm status -total-only
4h27m0s

It has the same output.

Also, I have tried this with admin(superuser/root) and non-admin mode for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants