Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several examples do not compile. #6

Open
16 tasks done
dominik-mokris-mtu opened this issue Mar 24, 2023 · 4 comments · May be fixed by #21
Open
16 tasks done

Several examples do not compile. #6

dominik-mokris-mtu opened this issue Mar 24, 2023 · 4 comments · May be fixed by #21
Assignees
@hverhelst

Comments

@dominik-mokris-mtu
Copy link
Contributor

dominik-mokris-mtu commented Mar 24, 2023 •
edited by hverhelst

When I build entire G+Smo with gsUnstructuredSplines with make (using gcc 11.2), there is an example from gsUnstructuredSplines that does not compile and several warnings.

  • kirchhoff-Love_weak_multipatch_buckling_example.cpp
In file included from [...]/gismo/optional/gsUnstructuredSplines/examples/kirchhoff-Love_weak_multipatch_buckling_example.cpp:23:0:
[...]/gismo/optional/gsSpectra/gsSpectra.h:23:10: fatal error: Spectra/include/Spectra/SymEigsSolver.h: No such file or directory
 #include <Spectra/include/Spectra/SymEigsSolver.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
  • biharmonic2_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic2_eigenvalue_example.cpp:243:13: warning: unused variable ‘systemRet’ [-Wunused-variable]
         int systemRet = system("mkdir -p ModalResults");
             ^~~~~~~~~
  • biharmonic2_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic2_eigenvalue_example.cpp:273:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     GISMO_ENSURE((omegas.size()>=values.rows()),"Too few analytical eigenvalues");
                   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~
  • biharmonic2_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic2_eigenvalue_example.cpp:281:13: warning: unused variable ‘systemRet’ [-Wunused-variable]
         int systemRet = system("mkdir -p ModalResults");
             ^~~~~~~~~
  • create_multipatch.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/create_multipatch.cpp:110:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             for (index_t p=0; p!=mp.nPatches(); p++)
                               ~^~~~~~~~~~~~~~~
  • create_multipatch.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/create_multipatch.cpp:112:28: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
                 if (hbasis = dynamic_cast<gsHTensorBasis<2,real_t> *>(&mp.basis(p)))
                     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • create_multipatch.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/create_multipatch.cpp:127:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                 for (index_t p=0; p!=mp.nPatches(); p++)
                                   ~^~~~~~~~~~~~~~~
  • biharmonic_planar_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_example.cpp:416:39: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                 for (index_t p = 0; p != geom.nPatches(); p++)
                                     ~~^~~~~~~~~~~~~~~~~~
  • biharmonic_planar_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_example.cpp:487:39: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                 for (index_t p = 0; p != geom0.nPatches(); p++)
                                     ~~^~~~~~~~~~~~~~~~~~~
  • biharmonic_planar_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_eigenvalue_example.cpp:553:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             for (index_t p = 0; p!=mp.nPatches(); p++)
                                 ~^~~~~~~~~~~~~~~
  • biharmonic_planar_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_eigenvalue_example.cpp:539:13: warning: unused variable ‘systemRet’ [-Wunused-variable]
         int systemRet = system("mkdir -p ModalResults");
             ^~~~~~~~~
  • biharmonic_planar_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_eigenvalue_example.cpp:572:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     GISMO_ENSURE(omegas.size()>=values.rows(),"Too few analytical eigenvalues");
                  ~~~~~~~~~~~~~^~~~~~~~~~~~~~~
  • biharmonic_surface_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_eigenvalue_example.cpp:580:13: warning: unused variable ‘systemRet’ [-Wunused-variable]
         int systemRet = system("mkdir -p ModalResults");
             ^~~~~~~~~
  • biharmonic_planar_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_eigenvalue_example.cpp:178:10: warning: unused variable ‘last’ [-Wunused-variable]
     bool last = false;
          ^~~~
  • biharmonic_planar_eigenvalue_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_planar_eigenvalue_example.cpp:180:10: warning: unused variable ‘cond’ [-Wunused-variable]
     bool cond = false;
          ^~~~
  • biharmonic_surface2_example.cpp
[...]/gismo/optional/gsUnstructuredSplines/examples/biharmonic_surface2_example.cpp:1069:10: warning: variable ‘laplace_u_ex’ set but not used [-Wunused-but-set-variable]
     auto laplace_u_ex = ev.getVariable(laplace, G);
          ^~~~~~~~~~~~
@dominik-mokris-mtu dominik-mokris-mtu mentioned this issue Mar 24, 2023
Closed
@dominik-mokris-mtu
Copy link
Contributor Author

I have updated the list of examples that don't compile. There's quite some improvement! (-:

@hverhelst
Copy link
Member

I have fixed all!

@dominik-mokris-mtu
Copy link
Contributor Author

Most. However, the first one still does not compile on my machine. Is it some external dependency?

@hverhelst hverhelst linked a pull request Feb 28, 2024 that will close this issue
Open
@hverhelst
Copy link
Member

You are correct. external/Spectra was still on my machine, hence it was fine, eventhough I disabled Spectra. Now I added the ifdefs.
I added it in PR #21 , closing this issue officially. The commits in main before should have also been in a separate PR, but I was too fast -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hverhelst hverhelst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compilation of examples gismo/gsUnstructuredSplines
2 participants
@hverhelst @dominik-mokris-mtu