Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches #14

Open
filiatra opened this issue Mar 28, 2019 · 3 comments
Open

Branches #14

filiatra opened this issue Mar 28, 2019 · 3 comments

Comments

@filiatra
Copy link
Member

there are 2 extra branches in gsElasticity.

Do we still need the other 2?
if yes, maybe we should merge stable in them ?
if no, we delete them ?

@filiatra filiatra changed the title Brabches Branches Mar 28, 2019
@filiatra
Copy link
Member Author

Another issue:

There are some files in
motor/unikl/

which use the removed files from unsupported.. Is it easy to update these ?

@shamanskiy
Copy link
Member

The two extra branches contain files/features from the old gsElasticity which I would like to include into the master branch but for which I haven't had time yet. Meanwhile, I would like to keep the master branch clean.

Regarding the files in motor/unikl: some are already transferred to gsElasticity/example. I can move the rest to the gsElasticity/elastToDo branch and rework them later. I don't think it makes sense to keep them in the motor submodule since they can't be compiled now that gsElasticity is removed from the unsupported submodule. And making motor/unikl dependant on an external submodule (gsElasticity) is probably a bad idea. What do you think?

@shamanskiy
Copy link
Member

shamanskiy commented Apr 24, 2019

Hi Angelos, this conversation has become a bit inactive. Are we still going to make gsElasticity public? The core is functional and I keep working on further features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants