Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsPointGrid use of integer types int and unsigned #664

Open
hverhelst opened this issue Nov 22, 2023 · 0 comments
Open

gsPointGrid use of integer types int and unsigned #664

hverhelst opened this issue Nov 22, 2023 · 0 comments
Assignees
Labels
suggestion an idea or plan put forward for consideration

Comments

@hverhelst
Copy link
Member

In the gsPointGrid class, we make use of int and unsigned, while (almost?) everywhere else in the code, we use shirt_t and index_t. I changed it locally, but some tests break down (e.g. gsRemapInterface_test:MatchingAffineTest1.). I realized that the change of the integer types in gsPointGrid could have quite an impact throughout G+Smo. However, maybe it is worth the effort?

@hverhelst hverhelst added the suggestion an idea or plan put forward for consideration label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion an idea or plan put forward for consideration
Projects
None yet
Development

No branches or pull requests

3 participants