New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eigen namespace renaming (error: Eigen is not defined) #619

Open

filiatra opened this issue Jun 7, 2023 · 0 comments

Assignees

Labels

info

Member

filiatra commented Jun 7, 2023

This Issue might arise after merging of PR #617.
There, Eigen namespace is renamed as gsEigen.

Fixing compilation errors amounts to update existing codes in the sense 👍
Eigen::xxx becomes gsEigen::xxx and also eigen macros are guarded as, eg:

#   define Eigen gsEigen
    EIGEN_MAKE_ALIGNED_OPERATOR_NEW
#   undef Eigen

The text was updated successfully, but these errors were encountered:

filiatra added the info label

filiatra assigned hverhelst and ckarampa

filiatra pinned this issue

filiatra mentioned this issue

Rename Eigen namespace to avoid conflicts with third parties, fixes #601 #617

Merged

j042 added a commit that referenced this issue


          include pybind11/eigen.h within the renaming block

ad0a766

related to #619

j042 mentioned this issue

Ft pip install pygismo #622

Merged

weinmueller unpinned this issue

weinmueller pinned this issue

filiatra added a commit that referenced this issue


          fix related to #621 and #619

f3e05c3

j042 added a commit that referenced this issue


          include pybind11/eigen.h within the renaming block

54fe213

related to #619

filiatra unpinned this issue

hverhelst pinned this issue

hhornik unpinned this issue

hhornik pinned this issue

dominik-mokris-mtu unpinned this issue

dominik-mokris-mtu pinned this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment