Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: warning when term="" #1226

Open
Junyi-99 opened this issue Nov 3, 2023 · 0 comments
Open

Feature Request: warning when term="" #1226

Junyi-99 opened this issue Nov 3, 2023 · 0 comments

Comments

@Junyi-99
Copy link

Junyi-99 commented Nov 3, 2023 •
edited

As mentioned in #1186 , giscus will not rendering when term= (equals to empty)

Here I also found that when datamapping=title and title contains any emoji (like 馃憤) the giscus will also set term=

I think it's better to warning user in console that datamapping was configured incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Junyi-99