Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route summary reporting error #61

Closed
blbal opened this issue Feb 18, 2023 · 10 comments · Fixed by #111
Closed

Route summary reporting error #61

blbal opened this issue Feb 18, 2023 · 10 comments · Fixed by #111
Labels
bug Something isn't working good first issue Good for newcomers pre-GSoC Issues for pre-selection

Comments

@blbal
Copy link

blbal commented Feb 18, 2023

In the "Distance" box of a driving route a time of 22 min 43 sec is calculated.
The "Route Summary" on the map when the mouse is over the route shows this as 1h 22 min.

Difficult to describe in words so see the attached screen grab.

screenshot_20230218_215159
@nilsnolde nilsnolde added bug Something isn't working good first issue Good for newcomers labels Feb 19, 2023
@Rohitkr2510
Copy link

Is this issue still open? I want to work on this issue.

@nilsnolde
Copy link
Member

Nope, it's solved already, just needs some review by us: #62

@Rohitkr2510
Copy link

Can you suggest some issues on which I can work?

@nilsnolde
Copy link
Member

E.g. #41?

May I ask the motivation? Just generally or to prepare for GSoC?

@Rohitkr2510
Copy link

To prepare for GSoC 2023.

@nilsnolde nilsnolde added the pre-GSoC Issues for pre-selection label Feb 27, 2023
@Devang0907
Copy link

can i get this issue for solving?

@nilsnolde
Copy link
Member

You can read right?

@Devang0907
Copy link

sorry, i mean how to start solving?

@nilsnolde
Copy link
Member

#81 (comment)

@Anmolgaur7
Copy link

Is this issue still open ??

@rakeshhotker rakeshhotker mentioned this issue Mar 9, 2023
Merged
nilsnolde pushed a commit that referenced this issue Mar 12, 2023
@rakeshhotker
Closes #61 "Route summary reporting error" (#111)
56b29a1 
* created a file in utils for the function reusability

* Worked on the suggested changes

* did the requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers pre-GSoC Issues for pre-selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #61 "Route summary reporting error" rakeshhotker/valhalla-app
5 participants
@nilsnolde @Rohitkr2510 @blbal @Anmolgaur7 @Devang0907