Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Releases to Master-Branch Updates #37

Open
AndreG-P opened this issue Nov 29, 2019 · 4 comments
Open

Restrict Releases to Master-Branch Updates #37

AndreG-P opened this issue Nov 29, 2019 · 4 comments

Comments

@AndreG-P
Copy link
Member

@physikerwelt Could it be that you forget to update the POM-versions (or we forget to specify that in travis)? vmext-demo depends on v. 2.0.2
https://github.com/ag-gipp/vmext-demo/blob/9a27896a1242d823d13f1161f49066c801c218ad/pom.xml#L61-L65

but all poms are still on 2.0.2-SNAPSHOT:
https://github.com/ag-gipp/MathMLTools/blob/77c69b6366a5b8720796d1cd9d155ba26c2f1b20/pom.xml#L9

Also, the releases are already on 2.0.4: https://github.com/ag-gipp/MathMLTools/tree/2.0.4
as well as maven central: https://search.maven.org/artifact/com.formulasearchengine.mathmltools/mathmltools/2.0.4/jar

Something we missed in .travis.yml?

@physikerwelt
Copy link
Member

physikerwelt commented Nov 29, 2019

master seems outdated. Mvn central releases correspond to GH tags

@AndreG-P
Copy link
Member Author

@physikerwelt
Got it.

I would like to keep it open because none of the other branches are ready to merge to master now (test fails). Also, why do we deploy on non-master branches? Isn't that a mistake?

@AndreG-P AndreG-P reopened this Nov 29, 2019
@AndreG-P AndreG-P assigned AndreG-P and unassigned physikerwelt Nov 29, 2019
@AndreG-P AndreG-P changed the title Versions are not correct? Restrict Releases to Master-Branch Updates Nov 29, 2019
@physikerwelt
Copy link
Member

The problem is that I was stuck in #34 and am still waiting for a reply there.

@AndreG-P
Copy link
Member Author

AndreG-P commented Dec 2, 2019

Sorry I missed that request. Thanks for pointing it out again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants