New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build breaks with node-neat and v1.1.1 #4
Comments
checking on it, tnx! |
@VitorLuizC reverting on my previous version this 1.0.3 this issue doesn't exists. I pushed a stable branch and published on npm version 1.2.0 (exactly equal as 1.0.3). Can you find the problem here ? |
@linkurzweg I'm trying to reproduce this issue. @giowe can you just rollback the stream treatment instead of using |
@linkurzweg can you paste here your |
@VitorLuizC, I don't know if that will actually help, because our build system is a bit complicated. There are multiple tasks in different files spread across multiple projects that share the same codebase to some extent. Can I send you the files directly? Thanks for looking into this :) Oh, I did have to revert to v1.0.3 to get everything working again, not 1.1.0. Sorry. |
@linkurzweg Can you provide the vars U're trying to inject? I could test if my PR is causing this. Also, bootstrap-sass, node-sass and other modules have issues like it. Can you confirm if those issues are related with this one? @giowe I will rollback your stream treatment and make another PR. |
@VitorLuizC , sure, this is the only var I try to inject: I can confirm that the issues are related. The "invalid mapping" error points to a line that is starting with an ampersand. However, with v1.2.0 of the package, everything seems to be fine :) |
I cannot build my project anymore with the latest version of the package.
I get the following error message:
`gulp-sass-vars: Injected 1 variables to sass:
$output-bourbon-deprecation-warnings: 'false';
node_modules/source-map/lib/source-map-generator.js:277
throw new Error('Invalid mapping: ' + JSON.stringify({
^
Error: Invalid mapping: {"generated":{"line":1,"column":29271},"source":"../../../../../../node_modules/bourbon-neat/app/assets/stylesheets/grid/_span-columns.scss","original":{"line":89,"column":-353},"name":null}`
The error appears in conjuction wiht node-neat, my task looks like this:
gulp.task(
css:${publication.name}, () => { return gulp.src(
${config.paths.scss}/styles.scss) .pipe(gulpif(process.env.watch === 'true', plumber({errorHandler: onWatchError}))) .pipe(newer({ dest:
${config.paths.target}/css/styles.css, extra: extraFiles })) .pipe(sourcemaps.init()) .pipe(sassVars(vars)) .pipe(sass({ outputStyle: 'expanded', includePaths: ['css:' + publication.name].concat(normalize, neat), errLogToConsole: true })) .pipe(sourcemaps.write('./')) .pipe(gulp.dest(
${config.paths.target}/css)) .pipe(touch()); })
If I go back to v1.1.0 everything works fine.
The text was updated successfully, but these errors were encountered: