Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional to allow for empty filter #10

Open
snomos opened this issue May 13, 2022 · 3 comments
Open

Update conditional to allow for empty filter #10

snomos opened this issue May 13, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@snomos
Copy link
Member

snomos commented May 13, 2022

There are cases where it does not make sense to filter repos based on tags. We need to update

if (doesTopicsHaveSomeFilter(repo.topics, filters)) {
tbody.appendChild(addTR(repo));
}

this to test for an empty or null filter, and in that case allow all repos to be added.

@snomos snomos added the enhancement New feature or request label May 13, 2022
@snomos
Copy link
Member Author

snomos commented Dec 16, 2022

@albbas could you take a look?

@albbas
Copy link
Contributor

albbas commented Jan 2, 2023

Does 56b6e76 fix this problem?

@snomos
Copy link
Member Author

snomos commented Jan 2, 2023

Code looks good, will check more thoroughly tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants