Turkish character issue

[burakereno]

Turkish characters are not work I downloaded using the application

• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Context

Your Environment

Tech	Version
app version	2
OS	High Siearra
etc

[c0b41]

i think problem caption-core iconv convert subtitle files..

[vernondegoede]

Thanks @burakereno, can you give me an example of your search query? What show did you search for when you encountered this problem?

It could indeed be an issue with caption-core. we need to add some tests there to check how we're handling character encoding.

[burakereno]

thanks @vernondegoede , I tried Shameless and Dunkirk. The same problem was appear but when ı manually downloaded on the website, Turkish character problem was disappear. The old version was work fine.

[gielcobben]

@burakereno we're working on a fix that will be released in a couple of days. To test it properly can you please send me the specific subtitle file downloaded manually from the source website?

Thanks.

[burakereno]

@gielcobben first of all thanks for be interested. I downloaded subtitles for Dunkirk and Shameless last season from this site http://www.turkcealtyazi.org/sub/693454/shameless.html
Work fine.

[burakereno]

did you fix this bug?

[vernondegoede]

Unfortunately, this bug hasn't been fixed (yet). We tried passing the encoding to caption-core but Node supports only a few encodings. We need to find a different way to handle unknown encodings.

List of supported encodings: https://stackoverflow.com/questions/14551608/list-of-encodings-that-node-js-supports

[BurakQzdemir]

if you do the encoding as utf8, the problem will be fixed.

[burakereno]

Guys, please fix this issue. I use Caption every day :)

[karolospre]

Hi. i still see this issue is not fixed. Am i right? I use it for Greek subs