Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest and coverage #45

Open
Zeitsperre opened this issue Mar 23, 2021 · 3 comments
Open

Use pytest and coverage #45

Zeitsperre opened this issue Mar 23, 2021 · 3 comments
Labels
New feature New feature or request

Comments

@Zeitsperre
Copy link
Contributor

I can see that a file package_test.py is in the top-level, but we could potentially make use of pytest to make the testing process much more standardized.

Testing for code coverage (https://pypi.org/project/pytest-cov/) might also be of interest for maintainability. If this is of interest, let me know.

@iamtekson
Copy link
Collaborator

Yes, you are right. We can add the pytest to make the testing process. But I am not familiar with this tool. You can please proceed. We can discuss further if you need any clearification.

@dvignoles
Copy link

I noticed that the tests contain hard coded file paths . Would it make sense to instead include the testing data as part of the repository? Or perhaps reference some data publicly available on the web?

In terms of integration testing with geoserver, it might also make sense to spin up a geoserver docker container as part of the test run. There's a library pytest-docker for just that sort of thing.

Let me know what you think. This package has been super helpful for me already and I'd like to contribute!

@iamtekson
Copy link
Collaborator

Hi @dvignoles, Thank you for addressing this issue. Please sure you can integrate the docker container as a part of the test run. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants