You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can see that a file package_test.py is in the top-level, but we could potentially make use of pytest to make the testing process much more standardized.
Testing for code coverage (https://pypi.org/project/pytest-cov/) might also be of interest for maintainability. If this is of interest, let me know.
The text was updated successfully, but these errors were encountered:
Yes, you are right. We can add the pytest to make the testing process. But I am not familiar with this tool. You can please proceed. We can discuss further if you need any clearification.
I noticed that the tests contain hard coded file paths . Would it make sense to instead include the testing data as part of the repository? Or perhaps reference some data publicly available on the web?
In terms of integration testing with geoserver, it might also make sense to spin up a geoserver docker container as part of the test run. There's a library pytest-docker for just that sort of thing.
Let me know what you think. This package has been super helpful for me already and I'd like to contribute!
I can see that a file
package_test.py
is in the top-level, but we could potentially make use ofpytest
to make the testing process much more standardized.Testing for code coverage (https://pypi.org/project/pytest-cov/) might also be of interest for maintainability. If this is of interest, let me know.
The text was updated successfully, but these errors were encountered: