Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more customization of requests usage #133

Open
fleimgruber opened this issue Jan 15, 2024 · 2 comments
Open

Enable more customization of requests usage #133

fleimgruber opened this issue Jan 15, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fleimgruber
Copy link

As a user, I want to use geoserver-rest with a GeoServer instance that provides self-signed SSL certificates.

As a user, I would like to customize the functions using the requests package to set verify=False, see docs.

A possible solution would be to accept a **kwargs in the user-facing APIs, e.g. get_featurestore

def get_featurestore(self, store_name: str, workspace: str):

and pass those **kwargs to the requests call

r = requests.get(url, auth=(self.username, self.password))

so that users could do get_featurestore(..., verify=False).

@fleimgruber fleimgruber changed the title Enable more customization of requests Enable more customization of requests usage Jan 15, 2024
@iamtekson
Copy link
Collaborator

Hi @fleimgruber, I like the idea. Feel free to raise the PR if you want.

@iamtekson iamtekson added enhancement New feature or request good first issue Good for newcomers labels Jan 17, 2024
@jacklinna
Copy link

that sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants