Request Interception is not enabled

[jef]

Description

Related: jef/streetmerchant#826

So it seems like it's a problem with the adblocker dependency. Adding this.page.removeListener('request', this.onRequest); to the adblocker code fixed my problem as well. Not sure what is happening since I'm not an expert on Puppeteer. I'm guessing that promise doesn't resolve and so when request interception is done later on in the code base it errors out. A ticket should probably be filed.

@howdoicomputer

[remusao]

Hey @jef,

Thanks for taking the time to open an issue here. I skimmed through the original discussion and it was not clear how I could reproduce the issue easily on my side. I see that streetmerchant uses the adblocker through the puppeteer-extra plugin and has some logic on top to enable/disable it as well as register custom listeners. I can have a look at the issue but I would need some reasonably small script to reproduce the issue if possible.

Best,
Rémi

[howdoicomputer]

Also, the removeListener function call was a false positive; seems to have broken after a bit.

[jef]

I'm sorry @remusao, this was an easy fix -- and silly on my part not to look into it.

Puppeteer looks to allow for request interceptions and we hadn't enabled it.

https://pptr.dev/#?product=Puppeteer&version=v5.5.0&show=api-pagesetrequestinterceptionvalue

Going to close this out. Thanks for your time and your thoughtful input.

[remusao]

Hey @jef,

I'm glad you found the root cause. No worries at all, I'm happy to help,

Best,
Rémi