Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"awaitCloseAnimation: true" does not sum the duration of all animations. #519

Open
tuiris opened this issue Aug 19, 2023 · 0 comments
Open

Comments

@tuiris
Copy link

tuiris commented Aug 19, 2023

First of all, congratulations on Micromodal. It's simple, lightweight and allows customization of the modal.

Our team has an experience to share:

If there is more than one animation running, Micromdal only recognizes the one that finishes first and ignores the others.

Example: when clicking on the close button (awaitCloseAnimation: true), animation A (lasting 1s, no delay) and animation B (lasting 1s, delay .5s) are triggered, then the modal closes on end of animation A interrupting animation B in half. To prevent this from happening, we are forced to finish the animations at the same time.

Also, we want to suggest better documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant