Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image Processing #434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

okyanusoz
Copy link

@okyanusoz okyanusoz commented Aug 11, 2023

@greggman
Copy link
Member

This issue is covered here: https://webglfundamentals.org/webgl/lessons/webgl-cors-permission.html

It's intentionally omitted here because otherwise I have explain everything in that article. Just setting crossDomain is not enough. The fact that it worked for you with picsum.photos is just luck that the picsum.photos site's server happens to set the right headers to give permission to use the image. Most sites do not

@okyanusoz
Copy link
Author

okyanusoz commented Aug 14, 2023

Maybe we could link to that article though, what do you think? Or should we close this? It'd be easier to find.

@greggman
Copy link
Member

I'm not sure what's best. I started to add a link to the article, the comment appears in 5 places, but I think maybe it's better just to remove the original comment instead (which I did) 6e7f809

There reason being, there are all kinds of side issues like this and if every place one of those side issues comes up you needed a link or an explanation it would get really hard to read. For example just this one issue in particular, effectively if I put the comment with a link to that article then for consistency, every single time a texture is mentioned I need the link to the article, all 57 times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webgl-image-processing: images don't actually have to be same-origin
2 participants