Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible bug in m3.js #390

Open
MaudDibb opened this issue Mar 1, 2022 · 1 comment
Open

possible bug in m3.js #390

MaudDibb opened this issue Mar 1, 2022 · 1 comment

Comments

@MaudDibb
Copy link

MaudDibb commented Mar 1, 2022

in m3.js, the inverse function:

const m00 = m[0 * 4 + 0];
const m01 = m[0 * 4 + 1];
const m02 = m[0 * 4 + 2];
const m10 = m[1 * 4 + 0];
const m11 = m[1 * 4 + 1];
const m12 = m[1 * 4 + 2];
const m20 = m[2 * 4 + 0];
const m21 = m[2 * 4 + 1];
const m22 = m[2 * 4 + 2];

should those 4's be 3's instead? you\re working with 3x3 matrices, not 4x4

@greggman
Copy link
Member

greggman commented Mar 1, 2022

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants