Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing square bracket in JSON export #36

Open
Mramorov opened this issue Sep 5, 2021 · 1 comment
Open

Closing square bracket in JSON export #36

Mramorov opened this issue Sep 5, 2021 · 1 comment

Comments

@Mramorov
Copy link

Mramorov commented Sep 5, 2021

Hello,
In the file 'json.go' responsible for json export, you open the file with the 'O_APPEND ' flag, so the closing square bracket instead of the last comma is not written to the file and this error is not processed.

@musabgultekin
Copy link
Collaborator

If you use json exporter, you need to close the exports chan in order last closing square bracked is processed.

If you mean This line https://github.com/geziyor/geziyor/blob/master/export/json.go#L73 It's a write error so even if we try to write the last square bracked I don't think we can get it successfully as it got file write error already.

What do you suggest for changing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants