Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

words overflow #36

Open
tshepang opened this issue Sep 23, 2019 · 6 comments
Open

words overflow #36

tshepang opened this issue Sep 23, 2019 · 6 comments

Comments

@tshepang
Copy link
Contributor

tshepang commented Sep 23, 2019

#33 introduced an issue where words overflow:

Screenshot from 2019-09-23 19-48-46

See these words: building, build, and nix.

@Keats
Copy link
Collaborator

Keats commented Sep 23, 2019

I think it just needs to set some word-wrapping somewhere in the CSS

@nyarvin
Copy link
Contributor

nyarvin commented Feb 8, 2020

The culprit is line 48 of sass/_main.sass:

  word-break: break-all;

Deleting that line fixes it.

There are other places in that file where the same line appears, but this is the one that applies to links in particular. Possibly the others should be fixed too. (Obviously this was someone's design decision, but it seems hard to regard it as anything but a bug: if your link text is so long and obscure that it's hard to wrap it, that should be your problem; don't fix it by randomly cutting in half other people's words.)

@Keats
Copy link
Collaborator

Keats commented Feb 8, 2020

@nyarvin can you do a PR?

@jclinton
Copy link

jclinton commented Jul 8, 2020

Did the merge fix this? I'm still seeing this at HEAD

@jclinton
Copy link

jclinton commented Jul 8, 2020

Actually, the only place I see the problem is on the About page and I just realized that word-break: break-all; was left in _main.scss on .about p > a line 277. What's was this line intended to help with?

@Keats
Copy link
Collaborator

Keats commented Jul 8, 2020

No clue, it's pretty old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants