Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url support for source bundles #1194

Closed
DamGouz opened this issue May 16, 2023 · 4 comments
Closed

Url support for source bundles #1194

DamGouz opened this issue May 16, 2023 · 4 comments
Labels
backlog Will be investigated and fixed at a later point

Comments

@DamGouz
Copy link

DamGouz commented May 16, 2023

It would be great if source bundles had support for fetching source files from a url, rather than from a file inside the zip file.
That way, we can fetch sources directly from Perforce by using Swarm urls, even though Perforce is not supported by sentry.

@Swatinem Swatinem added the backlog Will be investigated and fixed at a later point label May 22, 2023
@Swatinem
Copy link
Member

In theory we have the ability to download individual source files for source context now, initially developed for the .NET source-link: #1103

There is also a long standing feature request to allow downloading the source code from debuginfod symbol servers:
#445

In theory we could add a new "filter" for symbol servers that contain source code, and a couple of special path schemes how to find that source code. However that would be a bigger feature, also tying into the whole external symbol server configuration in sentry itself.

@DamGouz
Copy link
Author

DamGouz commented May 22, 2023

But what about adding that exact same source-link feature in source bundles, as we don't always have control over the event context.

@Swatinem
Copy link
Member

I would assume the SourceBundle manifest would need to be adapted for that, probably with some non-trivial changes.
Not to mention than you would have to somehow upload such a special SourceBundle via sentry-cli somehow…

@Swatinem
Copy link
Member

As discussed in chat, I believe all the missing pieces here are implemented.

We have put in sourcelink support into the SourceBundle manifest format, however it is currently only aimed at "power users", as it requires manually building a SourceBundle.

Support for authentication was also added, using the same form that we use for JS scraping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Will be investigated and fixed at a later point
Projects
None yet
Development

No branches or pull requests

2 participants