From 9b971d786476a93e24be3cdc686c38162ed6d13a Mon Sep 17 00:00:00 2001 From: Riya Chakraborty Date: Wed, 20 Mar 2024 14:12:39 -0700 Subject: [PATCH 1/2] remove dlq limits --- rust_snuba/src/consumer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust_snuba/src/consumer.rs b/rust_snuba/src/consumer.rs index 21a8c549e7..79a9547b19 100644 --- a/rust_snuba/src/consumer.rs +++ b/rust_snuba/src/consumer.rs @@ -166,8 +166,8 @@ pub fn consumer_impl( handle, kafka_dlq_producer, DlqLimit { - max_invalid_ratio: Some(0.01), - max_consecutive_count: Some(1000), + max_invalid_ratio: None, + max_consecutive_count: None, }, None, ) From ee1037b03b2384fc5801b1e5ea49935a029c4734 Mon Sep 17 00:00:00 2001 From: Riya Chakraborty Date: Wed, 20 Mar 2024 14:34:51 -0700 Subject: [PATCH 2/2] remove dlq limits in python consumer builder --- snuba/consumers/consumer_builder.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/snuba/consumers/consumer_builder.py b/snuba/consumers/consumer_builder.py index 928e88cc85..1571e06ccc 100644 --- a/snuba/consumers/consumer_builder.py +++ b/snuba/consumers/consumer_builder.py @@ -396,8 +396,8 @@ def __build_default_dlq_policy(self) -> Optional[DlqPolicy[KafkaPayload]]: Topic(self.__consumer_config.dlq_topic.physical_topic_name), ), DlqLimit( - max_invalid_ratio=0.01, - max_consecutive_count=1000, + max_invalid_ratio=None, + max_consecutive_count=None, ), None, )