Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert rules quantity limits monitoring #67195

Closed
pavlo-by-MA opened this issue Mar 18, 2024 · 4 comments · Fixed by #70596
Closed

Alert rules quantity limits monitoring #67195

pavlo-by-MA opened this issue Mar 18, 2024 · 4 comments · Fixed by #70596
Assignees
@saponifi3d
Labels
Product Area: Alerts Type: Feature Request
Milestone
FY'25 Q1 Alerts S...

Comments

@pavlo-by-MA
Copy link

Problem Statement

As I've got information from support - Sentry has limit for 1000 alert rules for 1 organization.

Due to this limit our team would like to know the way of monitoring quantity of alerts for 1 organization slug. Performing such monitoring makes possible to know exact time when number of alerts reaching limit.

Solution Brainstorm

Add alerts quantity to any API endpoint that will allow parse exact field and create alert rules quantity monitoring. A little similar example described here, but there are no alert rules quantity at all.

Product Area

Alerts
@getsantry
Copy link
Contributor

getsantry bot commented Mar 18, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 19, 2024

Routing to @getsentry/product-owners-alerts for triage ⏲️

@leedongwei
Copy link
Member

Make sense. We should surface this in the product UI too.

@rachrwang rachrwang added this to the FY'25 Q1 Alerts Small Fixes milestone Mar 22, 2024
@saponifi3d saponifi3d mentioned this issue May 9, 2024
Merged
saponifi3d added a commit that referenced this issue May 9, 2024
@saponifi3d
Add limit to API for Alert Rules (#70596)
e8f6cb0 
## Description
Fixes: #67195

Adds the `x-sentry-rule-limit` header to the list views for alert rules
(both the combined-rules and metric alert api).

I tried adding an indicator to the UI, but it was pretty difficult to
tell which page we're on in the UI, since we're handling it on the
backend with a `Link`. Rather than blocking the API fix on trying to
figure out the UI, i figure it's better to get this out and we can add
to the UI later.

![Screenshot 2024-05-09 at 11 39
43 AM](https://github.com/getsentry/sentry/assets/1569818/3cb0d796-95ad-4f87-8344-88d9599b6c79)
@saponifi3d
Copy link
Contributor

We updated the API to include the X-Sentry-Alert-Rule-Limit header when making GET requests for alert rules to include the limit for alert rules. To help make it a little easier to do pagination, we also added the number of alert rules that exist as well: X-Sentry-Alert-Rule-Hits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saponifi3d saponifi3d

Labels
Product Area: Alerts Type: Feature Request
Projects
GitHub Issues with 👀 2
Archived in project
Milestone
FY'25 Q1 Alerts Small Fixes
Development

Successfully merging a pull request may close this issue.

Add limit to API for Alert Rules getsentry/sentry
5 participants
@saponifi3d @leedongwei @rachrwang @Kobby-Bawuah @pavlo-by-MA