-
-
Notifications
You must be signed in to change notification settings - Fork 4k
/
test_event_frequency.py
520 lines (447 loc) · 18.4 KB
/
test_event_frequency.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
import time
from copy import deepcopy
from datetime import timedelta
from unittest.mock import patch
from uuid import uuid4
import pytest
from django.utils import timezone
from sentry.issues.grouptype import PerformanceNPlusOneGroupType
from sentry.models.rule import Rule
from sentry.rules.conditions.event_frequency import (
EventFrequencyCondition,
EventFrequencyPercentCondition,
EventUniqueUserFrequencyCondition,
)
from sentry.testutils.abstract import Abstract
from sentry.testutils.cases import PerformanceIssueTestCase, RuleTestCase, SnubaTestCase
from sentry.testutils.helpers.datetime import before_now, freeze_time, iso_format
from sentry.testutils.silo import region_silo_test
from sentry.testutils.skips import requires_snuba
from sentry.utils.samples import load_data
pytestmark = [pytest.mark.sentry_metrics, requires_snuba]
class ErrorEventMixin(SnubaTestCase):
def add_event(self, data, project_id, timestamp):
data["timestamp"] = iso_format(timestamp)
# Store an error event
event = self.store_event(
data=data,
project_id=project_id,
)
return event.for_group(event.group)
class PerfIssuePlatformEventMixin(PerformanceIssueTestCase):
def add_event(self, data, project_id, timestamp):
fingerprint = data["fingerprint"][0]
fingerprint = (
fingerprint
if "-" in fingerprint
else f"{PerformanceNPlusOneGroupType.type_id}-{data['fingerprint'][0]}"
)
event_data = load_data(
"transaction-n-plus-one",
timestamp=timestamp,
start_timestamp=timestamp,
fingerprint=[fingerprint],
)
event_data["user"] = {"id": uuid4().hex}
event_data["environment"] = data.get("environment")
for tag in event_data["tags"]:
if tag[0] == "environment":
tag[1] = data.get("environment")
break
else:
event_data["tags"].append(data.get("environment"))
# Store a performance event
event = self.create_performance_issue(
event_data=event_data,
project_id=project_id,
fingerprint=fingerprint,
)
return event
@pytest.mark.snuba_ci
class StandardIntervalTestBase(SnubaTestCase, RuleTestCase):
__test__ = Abstract(__module__, __qualname__)
def add_event(self, data, project_id, timestamp):
raise NotImplementedError
def increment(self, event, count, environment=None, timestamp=None):
raise NotImplementedError
def _run_test(self, minutes, data, passes, add_events=False):
if not self.environment:
self.environment = self.create_environment(name="prod")
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
environment_rule = self.get_rule(data=data, rule=Rule(environment_id=self.environment.id))
event = self.add_event(
data={
"fingerprint": ["something_random"],
"user": {"id": uuid4().hex},
},
project_id=self.project.id,
timestamp=before_now(minutes=minutes),
)
if add_events:
self.increment(
event,
data["value"] + 1,
environment=self.environment.name,
timestamp=timezone.now() - timedelta(minutes=minutes),
)
self.increment(
event,
data["value"] + 1,
timestamp=timezone.now() - timedelta(minutes=minutes),
)
if passes:
self.assertPasses(rule, event, is_new=False)
self.assertPasses(environment_rule, event, is_new=False)
else:
self.assertDoesNotPass(rule, event, is_new=False)
self.assertDoesNotPass(environment_rule, event, is_new=False)
def test_one_minute_with_events(self):
data = {"interval": "1m", "value": 6}
self._run_test(data=data, minutes=1, passes=True, add_events=True)
data = {"interval": "1m", "value": 16}
self._run_test(data=data, minutes=1, passes=False)
def test_one_hour_with_events(self):
data = {"interval": "1h", "value": 6}
self._run_test(data=data, minutes=60, passes=True, add_events=True)
data = {"interval": "1h", "value": 16}
self._run_test(data=data, minutes=60, passes=False)
def test_one_day_with_events(self):
data = {"interval": "1d", "value": 6}
self._run_test(data=data, minutes=1440, passes=True, add_events=True)
data = {"interval": "1d", "value": 16}
self._run_test(data=data, minutes=1440, passes=False)
def test_one_week_with_events(self):
data = {"interval": "1w", "value": 6}
self._run_test(data=data, minutes=10080, passes=True, add_events=True)
data = {"interval": "1w", "value": 16}
self._run_test(data=data, minutes=10080, passes=False)
def test_one_minute_no_events(self):
data = {"interval": "1m", "value": 6}
self._run_test(data=data, minutes=1, passes=False)
def test_one_hour_no_events(self):
data = {"interval": "1h", "value": 6}
self._run_test(data=data, minutes=60, passes=False)
def test_one_day_no_events(self):
data = {"interval": "1d", "value": 6}
self._run_test(data=data, minutes=1440, passes=False)
def test_one_week_no_events(self):
data = {"interval": "1w", "value": 6}
self._run_test(data=data, minutes=10080, passes=False)
def test_comparison(self):
# Test data is 4 events in the current period and 2 events in the comparison period, so
# a 100% increase.
event = self.add_event(
data={
"fingerprint": ["something_random"],
"user": {"id": uuid4().hex},
},
project_id=self.project.id,
timestamp=before_now(minutes=1),
)
self.increment(
event,
3,
timestamp=timezone.now() - timedelta(minutes=1),
)
self.increment(
event,
2,
timestamp=timezone.now() - timedelta(days=1, minutes=20),
)
data = {
"interval": "1h",
"value": 99,
"comparisonType": "percent",
"comparisonInterval": "1d",
}
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
self.assertPasses(rule, event, is_new=False)
data = {
"interval": "1h",
"value": 101,
"comparisonType": "percent",
"comparisonInterval": "1d",
}
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
self.assertDoesNotPass(rule, event, is_new=False)
def test_comparison_empty_comparison_period(self):
# Test data is 1 event in the current period and 0 events in the comparison period. This
# should always result in 0 and never fire.
event = self.add_event(
data={
"fingerprint": ["something_random"],
"user": {"id": uuid4().hex},
},
project_id=self.project.id,
timestamp=before_now(minutes=1),
)
data = {
"interval": "1h",
"value": 0,
"comparisonType": "percent",
"comparisonInterval": "1d",
}
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
self.assertDoesNotPass(rule, event, is_new=False)
data = {
"interval": "1h",
"value": 100,
"comparisonType": "percent",
"comparisonInterval": "1d",
}
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
self.assertDoesNotPass(rule, event, is_new=False)
@patch("sentry.rules.conditions.event_frequency.BaseEventFrequencyCondition.get_rate")
def test_is_new_issue_skips_snuba(self, mock_get_rate):
# Looking for more than 1 event
data = {"interval": "1m", "value": 6}
minutes = 1
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
environment_rule = self.get_rule(data=data, rule=Rule(environment_id=self.environment.id))
event = self.add_event(
data={
"fingerprint": ["something_random"],
"user": {"id": uuid4().hex},
},
project_id=self.project.id,
timestamp=before_now(minutes=minutes),
)
# Issue is new and is the first event
self.assertDoesNotPass(rule, event, is_new=True)
self.assertDoesNotPass(environment_rule, event, is_new=True)
assert mock_get_rate.call_count == 0
class EventFrequencyConditionTestCase(StandardIntervalTestBase):
__test__ = Abstract(__module__, __qualname__)
rule_cls = EventFrequencyCondition
def increment(self, event, count, environment=None, timestamp=None):
timestamp = timestamp if timestamp else before_now(minutes=1)
data = {"fingerprint": event.data["fingerprint"]}
if environment:
data["environment"] = environment
for _ in range(count):
self.add_event(
data=data,
project_id=self.project.id,
timestamp=timestamp,
)
class EventUniqueUserFrequencyConditionTestCase(StandardIntervalTestBase):
__test__ = Abstract(__module__, __qualname__)
rule_cls = EventUniqueUserFrequencyCondition
def increment(self, event, count, environment=None, timestamp=None):
timestamp = timestamp if timestamp else before_now(minutes=1)
data = {"fingerprint": event.data["fingerprint"]}
if environment:
data["environment"] = environment
for _ in range(count):
event_data = deepcopy(data)
event_data["user"] = {"id": uuid4().hex}
self.add_event(
data=event_data,
project_id=self.project.id,
timestamp=timestamp,
)
class EventFrequencyPercentConditionTestCase(SnubaTestCase, RuleTestCase):
__test__ = Abstract(__module__, __qualname__)
rule_cls = EventFrequencyPercentCondition
def add_event(self, data, project_id, timestamp):
raise NotImplementedError
def _make_sessions(self, num):
received = time.time()
def make_session(i):
return dict(
distinct_id=uuid4().hex,
session_id=uuid4().hex,
org_id=self.project.organization_id,
project_id=self.project.id,
status="ok",
seq=0,
release="foo@1.0.0",
environment="prod",
retention_days=90,
duration=None,
errors=0,
# The line below is crucial to spread sessions throughout the time period.
started=received - i,
received=received,
)
self.bulk_store_sessions([make_session(i) for i in range(num)])
def _run_test(self, minutes, data, passes, add_events=False):
if not self.environment or self.environment.name != "prod":
self.environment = self.create_environment(name="prod")
if not hasattr(self, "test_event"):
self.test_event = self.add_event(
data={
"fingerprint": ["something_random"],
"user": {"id": uuid4().hex},
"environment": self.environment.name,
},
project_id=self.project.id,
timestamp=before_now(minutes=minutes),
)
if add_events:
self.increment(
self.test_event,
max(1, int(minutes / 2)) - 1,
environment=self.environment.name,
timestamp=timezone.now() - timedelta(minutes=minutes),
)
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
environment_rule = self.get_rule(data=data, rule=Rule(environment_id=self.environment.id))
if passes:
self.assertPasses(rule, self.test_event, is_new=False)
self.assertPasses(environment_rule, self.test_event, is_new=False)
else:
self.assertDoesNotPass(rule, self.test_event)
self.assertDoesNotPass(environment_rule, self.test_event)
def increment(self, event, count, environment=None, timestamp=None):
data = {
"fingerprint": event.data["fingerprint"],
}
timestamp = timestamp if timestamp else before_now(minutes=1)
if environment:
data["environment"] = environment
for _ in range(count):
event_data = deepcopy(data)
event_data["user"] = {"id": uuid4().hex}
self.add_event(
data=event_data,
project_id=self.project.id,
timestamp=timestamp,
)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_five_minutes_with_events(self):
self._make_sessions(60)
data = {"interval": "5m", "value": 39}
self._run_test(data=data, minutes=5, passes=True, add_events=True)
data = {"interval": "5m", "value": 41}
self._run_test(data=data, minutes=5, passes=False)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_ten_minutes_with_events(self):
self._make_sessions(60)
data = {"interval": "10m", "value": 49}
self._run_test(data=data, minutes=10, passes=True, add_events=True)
data = {"interval": "10m", "value": 51}
self._run_test(data=data, minutes=10, passes=False)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_thirty_minutes_with_events(self):
self._make_sessions(60)
data = {"interval": "30m", "value": 49}
self._run_test(data=data, minutes=30, passes=True, add_events=True)
data = {"interval": "30m", "value": 51}
self._run_test(data=data, minutes=30, passes=False)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_one_hour_with_events(self):
self._make_sessions(60)
data = {"interval": "1h", "value": 49}
self._run_test(data=data, minutes=60, add_events=True, passes=True)
data = {"interval": "1h", "value": 51}
self._run_test(data=data, minutes=60, passes=False)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_five_minutes_no_events(self):
self._make_sessions(60)
data = {"interval": "5m", "value": 39}
self._run_test(data=data, minutes=5, passes=True, add_events=True)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_ten_minutes_no_events(self):
self._make_sessions(60)
data = {"interval": "10m", "value": 49}
self._run_test(data=data, minutes=10, passes=True, add_events=True)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_thirty_minutes_no_events(self):
self._make_sessions(60)
data = {"interval": "30m", "value": 49}
self._run_test(data=data, minutes=30, passes=True, add_events=True)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_one_hour_no_events(self):
self._make_sessions(60)
data = {"interval": "1h", "value": 49}
self._run_test(data=data, minutes=60, passes=False)
@patch("sentry.rules.conditions.event_frequency.MIN_SESSIONS_TO_FIRE", 1)
def test_comparison(self):
self._make_sessions(10)
# Create sessions for previous period
self._make_sessions(10)
# Test data is 2 events in the current period and 1 events in the comparison period.
# Number of sessions is 20 in each period, so current period is 20% of sessions, prev
# is 10%. Overall a 100% increase comparitively.
event = self.add_event(
data={"fingerprint": ["something_random"]},
project_id=self.project.id,
timestamp=before_now(minutes=1),
)
self.increment(
event,
1,
timestamp=timezone.now() - timedelta(minutes=1),
)
self.increment(
event,
1,
timestamp=timezone.now() - timedelta(days=1, minutes=20),
)
data = {
"interval": "1h",
"value": 99,
"comparisonType": "percent",
"comparisonInterval": "1d",
}
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
self.assertPasses(rule, event, is_new=False)
data = {
"interval": "1h",
"value": 101,
"comparisonType": "percent",
"comparisonInterval": "1d",
}
rule = self.get_rule(data=data, rule=Rule(environment_id=None))
self.assertDoesNotPass(rule, event, is_new=False)
@freeze_time(
(timezone.now() - timedelta(days=2)).replace(hour=12, minute=40, second=0, microsecond=0)
)
@region_silo_test
class ErrorIssueFrequencyConditionTestCase(ErrorEventMixin, EventFrequencyConditionTestCase):
pass
@freeze_time(
(timezone.now() - timedelta(days=2)).replace(hour=12, minute=40, second=0, microsecond=0)
)
@region_silo_test
class PerfIssuePlatformIssueFrequencyConditionTestCase(
PerfIssuePlatformEventMixin,
EventFrequencyConditionTestCase,
):
pass
@freeze_time(
(timezone.now() - timedelta(days=2)).replace(hour=12, minute=40, second=0, microsecond=0)
)
@region_silo_test
class ErrorIssueUniqueUserFrequencyConditionTestCase(
ErrorEventMixin,
EventUniqueUserFrequencyConditionTestCase,
):
pass
@freeze_time(
(timezone.now() - timedelta(days=2)).replace(hour=12, minute=40, second=0, microsecond=0)
)
@region_silo_test
class PerfIssuePlatformIssueUniqueUserFrequencyConditionTestCase(
PerfIssuePlatformEventMixin,
EventUniqueUserFrequencyConditionTestCase,
):
pass
@freeze_time(
(timezone.now() - timedelta(days=2)).replace(hour=12, minute=40, second=0, microsecond=0)
)
@region_silo_test
class ErrorIssueEventFrequencyPercentConditionTestCase(
ErrorEventMixin, EventFrequencyPercentConditionTestCase
):
pass
@freeze_time(
(timezone.now() - timedelta(days=2)).replace(hour=12, minute=40, second=0, microsecond=0)
)
@region_silo_test
class PerfIssuePlatformIssueEventFrequencyPercentConditionTestCase(
PerfIssuePlatformEventMixin,
EventFrequencyPercentConditionTestCase,
):
pass