-
-
Notifications
You must be signed in to change notification settings - Fork 4k
/
sentryapps.py
475 lines (356 loc) · 17.2 KB
/
sentryapps.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
from __future__ import annotations
from functools import wraps
from typing import Any
from django.http import Http404
from rest_framework.exceptions import PermissionDenied
from rest_framework.permissions import BasePermission
from rest_framework.request import Request
from rest_framework.response import Response
from rest_framework.serializers import ValidationError
from sentry.api.authentication import ClientIdSecretAuthentication
from sentry.api.base import Endpoint
from sentry.api.bases.integration import PARANOID_GET
from sentry.api.permissions import SentryPermission, StaffPermissionMixin
from sentry.auth.staff import is_active_staff
from sentry.auth.superuser import is_active_superuser, superuser_has_permission
from sentry.coreapi import APIError
from sentry.middleware.stats import add_request_metric_tags
from sentry.models.integrations.sentry_app import SentryApp
from sentry.models.organization import OrganizationStatus
from sentry.services.hybrid_cloud.app import RpcSentryApp, app_service
from sentry.services.hybrid_cloud.organization import (
RpcUserOrganizationContext,
organization_service,
)
from sentry.services.hybrid_cloud.user import RpcUser
from sentry.services.hybrid_cloud.user.service import user_service
from sentry.utils.sdk import configure_scope
from sentry.utils.strings import to_single_line_str
COMPONENT_TYPES = ["stacktrace-link", "issue-link"]
def catch_raised_errors(func):
@wraps(func)
def wrapped(self, *args, **kwargs):
try:
return func(self, *args, **kwargs)
except APIError as e:
return Response({"detail": e.msg}, status=400)
return wrapped
def ensure_scoped_permission(request, allowed_scopes):
"""
Verifies the User making the request has at least one required scope for
the endpoint being requested.
If no scopes were specified in a ``scope_map``, it means the endpoint should
not be accessible. That is, this function expects every accessible endpoint
to have a list of scopes.
That list of scopes may be empty, implying that the User does not need any
specific scope and the endpoint is public.
"""
# If no scopes were found at all, the endpoint should not be accessible.
if allowed_scopes is None:
return False
# If there are no scopes listed, it implies a public endpoint.
if len(allowed_scopes) == 0:
return True
return any(request.access.has_scope(s) for s in set(allowed_scopes))
def add_integration_platform_metric_tag(func):
@wraps(func)
def wrapped(self, *args, **kwargs):
add_request_metric_tags(self.request, integration_platform=True)
return func(self, *args, **kwargs)
return wrapped
class SentryAppsPermission(SentryPermission):
scope_map = {
"GET": PARANOID_GET,
"POST": ("org:write", "org:admin"),
}
def has_object_permission(self, request: Request, view, context: RpcUserOrganizationContext):
if not hasattr(request, "user") or not request.user:
return False
self.determine_access(request, context)
if superuser_has_permission(request):
return True
# User must be a part of the Org they're trying to create the app in.
if context.organization.status != OrganizationStatus.ACTIVE or not context.member:
raise Http404
return ensure_scoped_permission(request, self.scope_map.get(request.method))
class SentryAppsAndStaffPermission(StaffPermissionMixin, SentryAppsPermission):
"""Allows staff to access the GET method of sentry apps endpoints."""
staff_allowed_methods = {"GET"}
class IntegrationPlatformEndpoint(Endpoint):
def dispatch(self, request, *args, **kwargs):
add_request_metric_tags(request, integration_platform=True)
return super().dispatch(request, *args, **kwargs)
class SentryAppsBaseEndpoint(IntegrationPlatformEndpoint):
permission_classes: tuple[type[BasePermission], ...] = (SentryAppsAndStaffPermission,)
def _get_organization_slug(self, request: Request):
organization_slug = request.json_body.get("organization")
if not organization_slug or not isinstance(organization_slug, str):
error_message = "Please provide a valid value for the 'organization' field."
raise ValidationError({"organization": to_single_line_str(error_message)})
return organization_slug
def _get_organization_for_superuser_or_staff(
self, user: RpcUser, organization_slug: str
) -> RpcUserOrganizationContext:
context = organization_service.get_organization_by_slug(
slug=organization_slug, only_visible=False, user_id=user.id
)
if context is None:
error_message = f"Organization '{organization_slug}' does not exist."
raise ValidationError({"organization": to_single_line_str(error_message)})
return context
def _get_organization_for_user(
self, user: RpcUser, organization_slug: str
) -> RpcUserOrganizationContext:
context = organization_service.get_organization_by_slug(
slug=organization_slug, only_visible=True, user_id=user.id
)
if context is None or context.member is None:
error_message = f"User does not belong to the '{organization_slug}' organization."
raise PermissionDenied(to_single_line_str(error_message))
return context
def _get_org_context(self, request: Request) -> RpcUserOrganizationContext:
organization_slug = self._get_organization_slug(request)
if is_active_superuser(request) or is_active_staff(request):
return self._get_organization_for_superuser_or_staff(request.user, organization_slug)
else:
return self._get_organization_for_user(request.user, organization_slug)
def convert_args(self, request: Request, *args, **kwargs):
"""
This baseclass is the the SentryApp collection endpoints:
[GET, POST] /sentry-apps
The GET endpoint is public and doesn't require (or handle) any query
params or request body.
The POST endpoint is for creating a Sentry App. Part of that creation
is associating it with the Organization that it's created within.
So in the case of POST requests, we want to pull the Organization out
of the request body so that we can ensure the User making the request
has access to it.
Since ``convert_args`` is conventionally where you materialize model
objects from URI params, we're applying the same logic for a param in
the request body.
"""
if not request.json_body:
return (args, kwargs)
context = self._get_org_context(request)
self.check_object_permissions(request, context)
kwargs["organization"] = context.organization
return (args, kwargs)
class SentryAppPermission(SentryPermission):
unpublished_scope_map = {
"GET": ("org:read", "org:integrations", "org:write", "org:admin"),
"PUT": ("org:write", "org:admin"),
"POST": ("org:admin",), # used for publishing an app
"DELETE": ("org:admin",),
}
published_scope_map = {
"GET": PARANOID_GET,
"PUT": ("org:write", "org:admin"),
"POST": ("org:admin",),
"DELETE": ("org:admin",),
}
@property
def scope_map(self):
return self.published_scope_map
def has_object_permission(self, request: Request, view, sentry_app: RpcSentryApp | SentryApp):
if not hasattr(request, "user") or not request.user:
return False
owner_app = organization_service.get_organization_by_id(
id=sentry_app.owner_id, user_id=request.user.id
)
self.determine_access(request, owner_app)
if superuser_has_permission(request):
return True
organizations = (
user_service.get_organizations(user_id=request.user.id)
if request.user.id is not None
else ()
)
# if app is unpublished, user must be in the Org who owns the app.
if not sentry_app.is_published:
if not any(sentry_app.owner_id == org.id for org in organizations):
raise Http404
# TODO(meredith): make a better way to allow for public
# endpoints. we can't use ensure_scoped_permission now
# that the public endpoint isn't denoted by '()'
if sentry_app.is_published and request.method == "GET":
return True
return ensure_scoped_permission(
request, self._scopes_for_sentry_app(sentry_app).get(request.method)
)
def _scopes_for_sentry_app(self, sentry_app):
if sentry_app.is_published:
return self.published_scope_map
else:
return self.unpublished_scope_map
class SentryAppAndStaffPermission(StaffPermissionMixin, SentryAppPermission):
"""Allows staff to access sentry app endpoints. Note that this is used for
endpoints acting on a single sentry app only."""
pass
class SentryAppBaseEndpoint(IntegrationPlatformEndpoint):
permission_classes: tuple[type[BasePermission], ...] = (SentryAppPermission,)
def convert_args(self, request: Request, sentry_app_slug: str, *args: Any, **kwargs: Any):
try:
sentry_app = SentryApp.objects.get(slug=sentry_app_slug)
except SentryApp.DoesNotExist:
raise Http404
self.check_object_permissions(request, sentry_app)
with configure_scope() as scope:
scope.set_tag("sentry_app", sentry_app.slug)
kwargs["sentry_app"] = sentry_app
return (args, kwargs)
class RegionSentryAppBaseEndpoint(IntegrationPlatformEndpoint):
def convert_args(self, request: Request, sentry_app_slug: str, *args: Any, **kwargs: Any):
sentry_app = app_service.get_sentry_app_by_slug(slug=sentry_app_slug)
if sentry_app is None:
raise Http404
self.check_object_permissions(request, sentry_app)
with configure_scope() as scope:
scope.set_tag("sentry_app", sentry_app.slug)
kwargs["sentry_app"] = sentry_app
return (args, kwargs)
class SentryAppInstallationsPermission(SentryPermission):
scope_map = {
"GET": ("org:read", "org:integrations", "org:write", "org:admin"),
"POST": ("org:integrations", "org:write", "org:admin"),
}
def has_object_permission(self, request: Request, view, organization):
if not hasattr(request, "user") or not request.user:
return False
self.determine_access(request, organization)
if superuser_has_permission(request):
return True
organizations = (
user_service.get_organizations(user_id=request.user.id)
if request.user.id is not None
else ()
)
if not any(organization.id == org.id for org in organizations):
raise Http404
return ensure_scoped_permission(request, self.scope_map.get(request.method))
class SentryAppInstallationsBaseEndpoint(IntegrationPlatformEndpoint):
permission_classes = (SentryAppInstallationsPermission,)
def convert_args(self, request: Request, organization_slug, *args, **kwargs):
if is_active_superuser(request):
organization = organization_service.get_org_by_slug(slug=organization_slug)
else:
organization = organization_service.get_org_by_slug(
slug=organization_slug, user_id=request.user.id
)
if organization is None:
raise Http404
self.check_object_permissions(request, organization)
kwargs["organization"] = organization
return (args, kwargs)
class SentryAppInstallationPermission(SentryPermission):
scope_map = {
"GET": ("org:read", "org:integrations", "org:write", "org:admin"),
"DELETE": ("org:integrations", "org:write", "org:admin"),
# NOTE(mn): The only POST endpoint right now is to create External
# Issues, which uses this baseclass since it's nested under an
# installation.
#
# The scopes below really only make sense for that endpoint. Any other
# nested endpoints will probably need different scopes - figure out how
# to deal with that when it happens.
"POST": ("org:integrations", "event:write", "event:admin"),
}
def has_permission(self, request: Request, *args, **kwargs):
# To let the app mark the installation as installed, we don't care about permissions
if (
hasattr(request, "user")
and hasattr(request.user, "is_sentry_app")
and request.user.is_sentry_app
and request.method == "PUT"
):
return True
return super().has_permission(request, *args, **kwargs)
def has_object_permission(self, request: Request, view, installation):
if not hasattr(request, "user") or not request.user:
return False
self.determine_access(request, installation.organization_id)
if superuser_has_permission(request):
return True
# if user is an app, make sure it's for that same app
if request.user.is_sentry_app:
return request.user.id == installation.sentry_app.proxy_user_id
# TODO(hybrid-cloud): Replace this RPC with an org member lookup when that exists?
org_context = organization_service.get_organization_by_id(
id=installation.organization_id,
user_id=request.user.id,
include_teams=False,
include_projects=False,
)
if (
org_context.member is None
or org_context.organization.status != OrganizationStatus.ACTIVE
):
raise Http404
return ensure_scoped_permission(request, self.scope_map.get(request.method))
class SentryAppInstallationBaseEndpoint(IntegrationPlatformEndpoint):
permission_classes: tuple[type[BasePermission], ...] = (SentryAppInstallationPermission,)
def convert_args(self, request: Request, uuid, *args, **kwargs):
installations = app_service.get_many(filter=dict(uuids=[uuid]))
installation = installations[0] if installations else None
if installation is None:
raise Http404
self.check_object_permissions(request, installation)
with configure_scope() as scope:
scope.set_tag("sentry_app_installation", installation.uuid)
kwargs["installation"] = installation
return (args, kwargs)
class SentryAppInstallationExternalIssuePermission(SentryAppInstallationPermission):
scope_map = {
"POST": ("event:read", "event:write", "event:admin"),
"DELETE": ("event:admin",),
}
class SentryAppInstallationExternalIssueBaseEndpoint(SentryAppInstallationBaseEndpoint):
permission_classes = (SentryAppInstallationExternalIssuePermission,)
class SentryAppAuthorizationsPermission(SentryPermission):
def has_object_permission(self, request: Request, view, installation):
if not hasattr(request, "user") or not request.user:
return False
installation_org_context = organization_service.get_organization_by_id(
id=installation.organization_id, user_id=request.user.id
)
self.determine_access(request, installation_org_context)
if not request.user.is_sentry_app:
return False
# Request must be made as the app's Proxy User, using their Client ID
# and Secret.
return request.user.id == installation.sentry_app.proxy_user_id
class SentryAppAuthorizationsBaseEndpoint(SentryAppInstallationBaseEndpoint):
authentication_classes = (ClientIdSecretAuthentication,)
permission_classes = (SentryAppAuthorizationsPermission,)
class SentryInternalAppTokenPermission(SentryPermission):
scope_map = {
"GET": ("org:write", "org:admin"),
"POST": ("org:write", "org:admin"),
"DELETE": ("org:write", "org:admin"),
}
def has_object_permission(self, request: Request, view, sentry_app):
if not hasattr(request, "user") or not request.user:
return False
owner_app = organization_service.get_organization_by_id(
id=sentry_app.owner_id, user_id=request.user.id
)
self.determine_access(request, owner_app)
if superuser_has_permission(request):
return True
return ensure_scoped_permission(request, self.scope_map.get(request.method))
class SentryAppStatsPermission(SentryPermission):
scope_map = {
"GET": ("org:read", "org:integrations", "org:write", "org:admin"),
# Anyone logged in can increment the stats, so leave the scopes empty
# Note: this only works for session-based auth so you cannot increment stats through API
"POST": (),
}
def has_object_permission(self, request: Request, view, sentry_app: SentryApp | RpcSentryApp):
if not hasattr(request, "user") or not request.user:
return False
owner_app = organization_service.get_organization_by_id(
id=sentry_app.owner_id, user_id=request.user.id
)
self.determine_access(request, owner_app)
if is_active_superuser(request):
return True
return ensure_scoped_permission(request, self.scope_map.get(request.method))