From 12934f7cafb5686a094eb693c974b837bc3c4884 Mon Sep 17 00:00:00 2001 From: Lyn Nagara Date: Fri, 1 Mar 2024 14:28:01 -0800 Subject: [PATCH 1/2] feat: Add retention values to DLQ --- topics/ingest-events-dlq.yaml | 2 ++ topics/ingest-generic-metrics-dlq.yaml | 2 ++ topics/ingest-metrics-dlq.yaml | 2 ++ topics/snuba-dead-letter-generic-metrics.yaml | 2 ++ topics/snuba-dead-letter-group-attributes.yaml | 2 ++ topics/snuba-dead-letter-metrics.yaml | 2 ++ topics/snuba-dead-letter-querylog.yaml | 2 ++ topics/snuba-dead-letter-replays.yaml | 2 ++ 8 files changed, 16 insertions(+) diff --git a/topics/ingest-events-dlq.yaml b/topics/ingest-events-dlq.yaml index 369adb1c..5d7ea7fc 100644 --- a/topics/ingest-events-dlq.yaml +++ b/topics/ingest-events-dlq.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/ingest-generic-metrics-dlq.yaml b/topics/ingest-generic-metrics-dlq.yaml index 074a9028..d02820a9 100644 --- a/topics/ingest-generic-metrics-dlq.yaml +++ b/topics/ingest-generic-metrics-dlq.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/ingest-metrics-dlq.yaml b/topics/ingest-metrics-dlq.yaml index a87313be..000b68eb 100644 --- a/topics/ingest-metrics-dlq.yaml +++ b/topics/ingest-metrics-dlq.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/snuba-dead-letter-generic-metrics.yaml b/topics/snuba-dead-letter-generic-metrics.yaml index bc4e21cf..d4073707 100644 --- a/topics/snuba-dead-letter-generic-metrics.yaml +++ b/topics/snuba-dead-letter-generic-metrics.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/snuba-dead-letter-group-attributes.yaml b/topics/snuba-dead-letter-group-attributes.yaml index a6793502..e8266f1c 100644 --- a/topics/snuba-dead-letter-group-attributes.yaml +++ b/topics/snuba-dead-letter-group-attributes.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/snuba-dead-letter-metrics.yaml b/topics/snuba-dead-letter-metrics.yaml index 634c3a60..0f25031f 100644 --- a/topics/snuba-dead-letter-metrics.yaml +++ b/topics/snuba-dead-letter-metrics.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/snuba-dead-letter-querylog.yaml b/topics/snuba-dead-letter-querylog.yaml index 7ff5f13b..6b02d0d2 100644 --- a/topics/snuba-dead-letter-querylog.yaml +++ b/topics/snuba-dead-letter-querylog.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" diff --git a/topics/snuba-dead-letter-replays.yaml b/topics/snuba-dead-letter-replays.yaml index b746fcf9..f6fe23d4 100644 --- a/topics/snuba-dead-letter-replays.yaml +++ b/topics/snuba-dead-letter-replays.yaml @@ -12,3 +12,5 @@ schemas: resource: any.json examples: - any/ +topic_creation_config: + log.retention.minutes: "10080" From cc6ae2181ef9c2b7ed0eaa307de511ecb5a850f0 Mon Sep 17 00:00:00 2001 From: Lyn Nagara Date: Fri, 1 Mar 2024 14:48:06 -0800 Subject: [PATCH 2/2] lol --- python/tests/test_sentry_kafka_schemas.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/tests/test_sentry_kafka_schemas.py b/python/tests/test_sentry_kafka_schemas.py index e9e38a30..e0a5d365 100644 --- a/python/tests/test_sentry_kafka_schemas.py +++ b/python/tests/test_sentry_kafka_schemas.py @@ -9,7 +9,7 @@ def test_get_topic() -> None: assert topic_data["topic_creation_config"] == {"max.message.bytes": "2000000"} # Topic without creation config - topic_name_no_config = "snuba-dead-letter-replays" + topic_name_no_config = "outcomes" topic_data = get_topic(topic_name_no_config) assert topic_data["topic_creation_config"] == {}