New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the deal with wrapConsoleMethod() ? #584
Comments
@grapho – console statements are collected and passed as breadcrumbs. I can see how it can be irritating that, as a result of instrumenting |
@benvinegar I promise I am not irritated... if there is a way i can use the breadcrumbs or an equivilant api in a development setting.. place of console.log, i would love to know how? |
i could get used to placing breakpoints and debugger statments instead.. if that is the perfered work around? |
I guess I rarely actually used the link to the console statement and didn't even notice it was gone :) I personally use the Chrome debugger most of the time.
You can use If this is not a serious blocker, I'd like to keep this issue open for a bit and see if we get any more feedback. |
I think this is a major issue, especially that its not documented anywhere and can't be disabled. Its up to the developer to choose what to send and when |
above comment appears to be incorrect, sorry. @benvinegar I appreciate you are willing to keep the ticket open, it might be worth investigating some more:) |
@benvinegar this issue is not a serious blocker at all. Here is my current solution. I realized I can just not initialize the raven.js client when in development mode... raven/sentry reporting, is only really useful to most people (i imagine) in production apps anyway. That being said. there might still be some use in introducing maybe a Let me know how you feel about that. Otherwise I would not worry too much about it, as this issue was mostly caused by my inexperience with raven and how/when to be using it. |
Real talk – do you actually want to disable this? I'm not trying to sound passive aggressive here, I just want to know if this is a serious problem right now and you want to disable it.
It is documented in the Raven.js changelog. We also published a blog post announcing breadcrumbs that mentions that Note also that this is why Raven.js 3.0.x was a major version bump, because it introduced potentially breaking changes. I hope that people are reviewing the changelog before upgrading to a major version.
In the meantime, you can still run Raven 2.x.
I want to collect more feedback before rushing into a solution. Especially since 3.0.x has been live for a couple weeks and most of the feedback we have gotten has been positive. |
Yeah, I had a feeling you were curious more than anything.
Yeah, the problem with that is that there is an argument for wanting console statements in production for debugging too. I'd rather just make it configurable. And, we will. I just want to get more feedback / measure impact first. Anwyays, appreciate both your comments here, really. |
@benvinegar: 👍 for config option — ideally allowing to filter out unwanted entries by hand (or rather function) |
This keeps coming up on the support tracker as well. I think we should add a method to disable it. |
Please make the breadcrumbs feature optional, wrapping console methods is risky and prone to conflicts with many other libs and 3rd party scripts that also try to. |
As of 3.5.0 you can disable automatic collection of console breadcrumbs: Raven.config('your dsn', {
autoBreadcrumbs: {
console: false
}
}); Or you can disable automatic breadcrumb collection entirely: Raven.config('your dsn', { autoBreadcrumbs: false }); More on this in docs. |
https://github.com/getsentry/raven-js/blob/master/typescript/raven.d.ts |
We've been struggling with TypeScript declarations lately. Submissions welcome. |
I noticed recently that raven now wraps up all the console methods, but I do not see any documentation that describes why? or how it could possibly be useful? Has anyone come across this yet and could point me to some documentation on its use?
the issue I come across is I can no longer do simple debugging with console.log() .. the source becomes raven.js and i can no longer track where in my code it is eminating from?
Originally posted on the docs repo, then closed
The text was updated successfully, but these errors were encountered: