Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't removeEventListener on version 5.19.1 in some cases #2734

Closed
5 of 6 tasks
scorpio13love opened this issue Jul 9, 2020 · 3 comments · Fixed by #2737
Closed
5 of 6 tasks

Couldn't removeEventListener on version 5.19.1 in some cases #2734

scorpio13love opened this issue Jul 9, 2020 · 3 comments · Fixed by #2737

Comments

@scorpio13love
Copy link

Package + Version

  • @sentry/browser
  • @sentry/integrations

Version:

5.19.1

Description

Some "removeEventListener methods" didn't work when i upgrade packages to version 5.19.1.

But things work out all right on previous version, such as version 5.15.1.

And i found that this config below will cause "callback.sentry" to be "undefined" which committed at 9a68a35

Sentry.init({
  // ...
  integrations: [new Sentry.Integrations.Breadcrumbs({ dom: false })]
});

Is this the reason that make event listeners which registered after sentry inited couldn't be remove ?

How to fix it ?

@kamilogorek
Copy link
Contributor

Are you able to provide some sort of repro-case? If there's indeed an issue, I'd like to get it fixed right away.

@scorpio13love
Copy link
Author

@kamilogorek
I created a repo like this :https://github.com/scorpio13love/sentry-dom-false.

  1. Input sentry "dsn".
  2. Click button to change router between "page home" and "page detail" several times.
  3. You can count the "page detail click" msg in DevTools Console Or look at the Document's Binding EventListeners.

@kamilogorek
Copy link
Contributor

@scorpio13love thanks, I'll look into it. From my first pass, it appears that disabling of dom breadcrumbs is causing it. Very odd though. Will get back to you once I find the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants