Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature scrubbing sensitive data support with sanitizeKeys #2391

Closed
ma2gedev opened this issue Jan 24, 2020 · 4 comments
Closed

Feature scrubbing sensitive data support with sanitizeKeys #2391

ma2gedev opened this issue Jan 24, 2020 · 4 comments

Comments

@ma2gedev
Copy link
Contributor

Is there a plan to support sanitizing data before send to the server? The following comment was found at #1564 but the issue was closed, so we would like to confirm the current status.

We will soon release a new way of how to strip sensitive data in SDKs, stay tuned.

#1564 (comment)

background

Current JavaScript SDK does not support this feature, users manually filter with beforeSend callback according to document. However former Raven.js supports this feature with sanitizeKeys, document here. And also other SDK supports this feature for example Ruby's SDK provides sanitize_fields.

It's worth to support this feature in new SDK when the user migrate from Raven.js to new Sentry SDK, or decide to use which SDK in new project.

Related resources

@kamilogorek
Copy link
Contributor

Hey, thanks for writing very detailed issue. We were thinking about adding this early on, however, it's not a very commonly used feature. And we already have a hard time to stay compact.
This is a very good candidate for an external integration that could be pulled down and configured from @sentry/integrations. Pull request would be much more than welcome :)

@ma2gedev
Copy link
Contributor Author

Thank you for you response! I try to look at @sentry/integrations first.

ma2gedev added a commit to ma2gedev/sentry-javascript that referenced this issue Feb 9, 2020
@ma2gedev
Copy link
Contributor Author

ma2gedev commented Feb 10, 2020

@kamilogorek Sorry for late response. I just created pull request #2422 . Thank you in advance. 👍

ma2gedev added a commit to ma2gedev/sentry-javascript that referenced this issue Feb 20, 2020
@kamilogorek
Copy link
Contributor

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants