Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a benchmark action #3332

Open
vaind opened this issue Apr 26, 2024 · 0 comments
Open

Add a benchmark action #3332

vaind opened this issue Apr 26, 2024 · 0 comments

Comments

@vaind
Copy link
Collaborator

vaind commented Apr 26, 2024

I've done away with the lambdas as well (these are now inline functions).

The tests seem to pass now. 馃巿

So indeed it seems like it has been the performance issue. Maybe we should check check that we have some benchmarks for these critical paths and introduce https://github.com/marketplace/actions/continuous-benchmark to the repo. Although it looks like it doesn't support PRs from outside contributors at the moment.

Originally posted by @vaind in #3321 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants