Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry assembly produces trim warnings when compiling AOT #3304

Open
jamescrosswell opened this issue Apr 16, 2024 · 1 comment
Open

Sentry assembly produces trim warnings when compiling AOT #3304

jamescrosswell opened this issue Apr 16, 2024 · 1 comment
Labels

Comments

@jamescrosswell
Copy link
Collaborator

Steps to reproduce

  1. Follow the Tutorial to Publish an ASP.NET Core app using Native AOT
  2. Add the Sentry.AspNetcore NuGet package to the applications
  3. Configure Sentry per the docs

Now publish the application again.

Expected Result

Application should publish without warnings.

Actual Result

The application is published correctly but the publish operation generates trim warnings:

MyFirstAotWebApi -> /Users/jamescrosswell/code/MyFirstAotWebApi/bin/Release/net8.0/osx-arm64/publish/
jamescrosswell@MacBook-Pro MyFirstAotWebApi % dotnet publish -f net8.0
MSBuild version 17.9.6+a4ecab324 for .NET
Determining projects to restore...
All projects are up-to-date for restore.
MyFirstAotWebApi -> /Users/jamescrosswell/code/MyFirstAotWebApi/bin/Release/net8.0/osx-arm64/MyFirstAotWebApi.dll
Generating native code
/Users/jamescrosswell/.nuget/packages/sentry/4.4.0/lib/net8.0/Sentry.dll : warning IL2104: Assembly 'Sentry' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/Users/jamescrosswell/code/MyFirstAotWebApi/MyFirstAotWebApi.csproj]
MyFirstAotWebApi -> /Users/jamescrosswell/code/MyFirstAotWebApi/bin/Release/net8.0/osx-arm64/publish/

Remarks

This is very odd as we explicitly set the IsAotCompatible MS Build property which should set IsTrimmable and enable the trim analyzer as well:

<PropertyGroup Condition="'$(FrameworkSupportsAot)' == 'true'">
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>

If there are any trim warnings then, we should be getting these when building Sentry for the net8.0 targets.

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Apr 22, 2024

This happened sporadically and was not 100% reproducible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants