Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ben.Demystifier for AOT apps #3230

Open
jamescrosswell opened this issue Mar 18, 2024 · 3 comments
Open

Enable Ben.Demystifier for AOT apps #3230

jamescrosswell opened this issue Mar 18, 2024 · 3 comments

Comments

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Mar 18, 2024

Off the back of the comments that triggered #3222 and #3223, could Ben.Demystifier be compiled with AOT now?

Maybe not, but needs further investigation when we have time.

TODO

Ben.Demystifier

Remaining work described here:

someone will need to do the work to enable the AOT/trim/single file safety analyzers and address all the warnings, but this is enough to have a golden path that makes sample/StackTrace project produce the same results under native AOT as under JIT.

Testing

Need to test to ensure this actually works with Sentry, of course. That will require some tweaks to the Sentry codebase to ensure it's possible to generate enhanced stack traces when compiling AOT (currently that's not possible).

@jamescrosswell
Copy link
Collaborator Author

@bitsandfoxes
Copy link
Contributor

I take it we can now try to enable it and see what happens?

@jamescrosswell
Copy link
Collaborator Author

There are some tasks described here.

I'll copy them into the description for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants