RequestsMock doesn't catch requests inside loop.run_in_executor(None, ...) #703

andrei-shabanski · 2024-01-31T15:32:07Z

Describe the bug

RequestsMock doesn't catch requests that are sent inside the default asyncio executor. As a result, real HTTP requests are sent.

Additional context

Python 3.9 - 3.11

Version of `responses`

0.24.1

Steps to Reproduce

import asyncio
import responses
import requests

def send_request():
    # Here a real HTTP request will be sent
    response = requests.get('https://example.com/')
    print(response.content)

def main():
    with responses.RequestsMock(assert_all_requests_are_fired=False) as rsps:
        rsps.get('https://example.com/', body='test')

        loop = asyncio.get_event_loop()
        loop.run_in_executor(None, send_request)
        # but   send_request()  works correct and DOES NOT send a real HTTP request

main()

Expected Result

test should be printed.

Actual Result

A real HTTP request is sent to https://example.com/, and a page body b'<!doctype html>\n<html>\n<head>\n <title>Example Domain</title>.... is printed.

The text was updated successfully, but these errors were encountered:

getsantry bot added the Waiting for: Product Owner label Jan 31, 2024

hubertdeng123 removed the Waiting for: Product Owner label Feb 1, 2024

markstory added the bug label Feb 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RequestsMock doesn't catch requests inside loop.run_in_executor(None, ...) #703

RequestsMock doesn't catch requests inside loop.run_in_executor(None, ...) #703

andrei-shabanski commented Jan 31, 2024 •

edited

RequestsMock doesn't catch requests inside loop.run_in_executor(None, ...) #703

RequestsMock doesn't catch requests inside loop.run_in_executor(None, ...) #703

Comments

andrei-shabanski commented Jan 31, 2024 • edited

Describe the bug

Additional context

Version of responses

Steps to Reproduce

Expected Result

Actual Result

andrei-shabanski commented Jan 31, 2024 •

edited

Version of `responses`