Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 page to pelicanthemes.com site #768

Open
justinmayer opened this issue Dec 12, 2023 · 3 comments
Open

Add 404 page to pelicanthemes.com site #768

justinmayer opened this issue Dec 12, 2023 · 3 comments

Comments

@justinmayer
Copy link
Member

The web server is currently configured to display /404.html when resources are not found, but since that file does not exist, the web server logs were filled with errors related to that missing file.

As an interim measure, I created a very simple 404 page for the pelicanthemes.com site at that location. As a more proper and longer-term solution, we should ensure that a 404.html page is created in the generated project root as part of the build process.

@mr4tt
Copy link

mr4tt commented Mar 31, 2024

hello! i tried to write a 404 page (https://github.com/mr4tt/pelican-themes) to fix the issue. this is my first time contributing to open source and i wasn't sure how to test that my code works, could i get some help on that?

thank you!

@avaris
Copy link
Member

avaris commented Apr 9, 2024

@mr4tt code looks good to me. Is that image original art? We would need permission or some permissive license to use it.

@mr4tt
Copy link

mr4tt commented Apr 9, 2024

Great!
I drew the pelican, you're free to use it however you want. How do I give formal permission for use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants