jr:choice-name parameters are not right

[lognaturel]

Everyone's favorite function, jr:choice-name, seems to be documented with arguments flipped. It should be jr:choice-name(node node, string value) I believe. Validate and Collect agree with that.

[MartijnR]

Oops, yes!

[lognaturel]

Unfortunately, I think this is not quite correct. I think where I got this from is that the typical call from XLSForm looks like jr:choice-name(${my_select_node}, '${my_select_node}').

From the implementation, I see that the first argument is the value to get the choice name for and the second argument is a string path representing the question that defines the select choices.

Comment in JavaRosa:

arg 1: select value
arg 2: string xpath referring to origin question

I think the way that https://docs.opendatakit.org/form-operators-functions#jr:choice-name is written is relatively helpful. The first argument can either be a path or a literal choice name.

This function is really bizarre and we should probably introduce a better alternative and deprecate it. I can't really think of a usecase for passing a choice name other than the value of the select question so it seems it would be much simpler to just have a single argument.