Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is seeing a backend message after trying to edit the submission that has closed or closing state #613

Open
srujner opened this issue Mar 15, 2024 · 1 comment
Labels
bug frontend Requires a change to the UI

Comments

@srujner
Copy link

srujner commented Mar 15, 2024

Problem description

Backend request is visible for the users instead of user friendly message.

URL of the page

https://staging.getodk.cloud/v1/projects/79/forms/multi%20warning/submissions/uuid%3A92604e98-6ea7-416a-9361-82fab90f3cde/edit

Steps to reproduce the problem

  1. Have at least one form in the project;
  2. Send Submission for a form;
  3. Navigate to the Form Access tab and change status of the form for Closing or Closed;
  4. Go back to Submission page and click on the Edit button

Screenshot

Screenshot(46)

Expected behavior

User friendly message should be visible

Central version shown in version.txt

106f533 (v2023.5.1-2-g106f533)
+00d84096788bbf31bd4ca903449848e8fd177159 client (v2023.5.0-34-g00d84096)
+e610ed1f41c1b04777c1779500c92d4cfea17ed0 server (v2023.5.0-30-ge610ed1f)

Browser version

Firefox 123.0.1

Around when did you see the problem (in UTC)?

10:10 AM UTC

@srujner srujner added the bug label Mar 15, 2024
@matthew-white
Copy link
Member

We're hoping to fix the root cause at some point so that users are able to edit submissions to closed or closing forms. There's been related discussion at getodk/central-backend#469. However, it hasn't been an easy fix so far, and I don't think we plan to address it in the very near future. In the meantime, I agree that it'd be nice to prevent the user from seeing this message from Backend. How about we disable the submission edit button if the form is closed or closing and show an informative tooltip? That's what we do for the form preview button, which faces the same restriction.

@matthew-white matthew-white added the frontend Requires a change to the UI label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend Requires a change to the UI
Projects
None yet
Development

No branches or pull requests

2 participants