Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send overly large request from Frontend #611

Open
matthew-white opened this issue Mar 13, 2024 · 0 comments
Open

Don't send overly large request from Frontend #611

matthew-white opened this issue Mar 13, 2024 · 0 comments
Labels
blocked Blocked by another issue frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

Before sending a file, Frontend checks that the file doesn't exceed the nginx limit of 100 MB. However, Frontend only checks that for files, not other request bodies, so it's possible for other large requests to be sent, resulting in a 413 error. Instead, it'd be better for Frontend to check all request bodies before sending them. (Though I'm not quite sure how to implement that. Can we access the Content-Length header somehow?)

This issue is labeled as "blocked", because we don't want to make this change until #609 is resolved. For now, we're taking the approach described in #610: allowing the request to be sent, but showing an informative error message. However, once #609 is resolved, it'd be good to prevent the request from being sent in the first place.

@matthew-white matthew-white added frontend Requires a change to the UI blocked Blocked by another issue labels Mar 13, 2024
@matthew-white matthew-white changed the title Don't send overly large request body from Frontend Don't send overly large request from Frontend Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue frontend Requires a change to the UI
Projects
None yet
Development

No branches or pull requests

1 participant