Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend does not reflect refresh if refresh canceled previous request #605

Open
matthew-white opened this issue Mar 8, 2024 · 0 comments
Labels
bug frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

Problem description

On the Submissions page and the entity Data page, if the refresh button is clicked, then the data is refreshed in the background. In other cases in which the data is refreshed, the table is removed while the request is in progress, e.g., after a filter is changed or after entities are uploaded. A background refresh does a few things differently compared to those requests:

  • The refresh button shows a spinner.
  • The button is disabled.
  • A loading message is not shown.

However, those differences do not activate if the refresh button is clicked while the previous request for OData is in progress: the button does not change, and a loading message is shown.

Steps to reproduce the problem

I only manually confirmed that this was an issue on the entity Data page. However, I'm pretty sure that it's an issue on the Submissions page as well.

  • Navigate to the entity Data page for an entity list with more than 250 entities.
  • Scroll to the bottom of the table. This triggers a request for the next entities in the table.
  • While that request is in progress, click the refresh button.
  • Clicking the refresh button cancels the request for the next entities in the table: only the request triggered by the refresh button is now in progress. However, observe that the refresh button does not show a spinner and is not disabled, and observe that there is a loading message below the table.
@matthew-white matthew-white added bug frontend Requires a change to the UI labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend Requires a change to the UI
Projects
None yet
Development

No branches or pull requests

1 participant