Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agent not saved for submission edit via OpenRosa #883

Open
matthew-white opened this issue May 19, 2023 · 1 comment
Open

User agent not saved for submission edit via OpenRosa #883

matthew-white opened this issue May 19, 2023 · 1 comment
Labels

Comments

@matthew-white
Copy link
Member

Steps to reproduce:

  • Create a submission.
  • Edit it using the OpenRosa API. Enketo may be the easiest way to do that.
  • Request the submission using the REST API.
  • Observe that currentVersion.userAgent is null.

From a quick look, it seems like we don't pass the user agent to Submissions.createVersion() for a submission edit via OpenRosa. Compare:

Via the REST API

Submissions.createVersion(partial, deprecated, form, query.deviceID, headers['user-agent']),

Via the OpenRosa API

Submissions.createVersion(partial, deprecated, form),

@matthew-white
Copy link
Member Author

matthew-white commented May 19, 2023

From the above, it looks like the device ID is also not saved for a submission edit via OpenRosa. However, Enketo doesn't send a device ID, so in practice that isn't really an issue. (At least for now: Enketo may start sending a device ID.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant