Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom metrics in the timeout middleware #99

Open
theburningmonk opened this issue Sep 26, 2019 · 5 comments
Open

Support custom metrics in the timeout middleware #99

theburningmonk opened this issue Sep 26, 2019 · 5 comments

Comments

@theburningmonk
Copy link
Contributor

This is a Feature Proposal

Description

  • Need a way to also track the occurrence of timeouts as a metric. Ideally a way to plug in datadog or newrelic clients to track custom metrics
@theburningmonk
Copy link
Contributor Author

cc @onlyplo

@theburningmonk
Copy link
Contributor Author

As I mentioned on the other thread, the simplest solution I can think of is to let you pass in a callback function, but let's carry on the discussed on the other thread.

@onlyplo
Copy link

onlyplo commented Sep 30, 2019

Yo, the initial work i have done here: d4f873b already starts to extend the middleware with a custom callback function.

Will probably need to change the naming and some logic based on our discussions to split off custom logging and custom metrics into separate issues.

Happy for me to submit a PR for this?

@theburningmonk
Copy link
Contributor Author

Sure, go for it!

@theburningmonk
Copy link
Contributor Author

@onlyplo any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants