Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns-client): add support for batch publish. #298

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sumit-ba
Copy link

@sumit-ba sumit-ba commented Mar 8, 2022

What did you implement:

Closes #297

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / projects / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@lkhari
Copy link
Contributor

lkhari commented Mar 15, 2022

@sumit-ba good work! From past PRs I've been told to ensure the coding styling remain consistant. So you may want to make those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support for batch publish in SNS client
2 participants