Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new custom CloudWatch embedded metric format #131

Open
theburningmonk opened this issue Nov 18, 2019 · 2 comments
Open

Support the new custom CloudWatch embedded metric format #131

theburningmonk opened this issue Nov 18, 2019 · 2 comments

Comments

@theburningmonk
Copy link
Contributor

This is a Feature Proposal

Description

CloudWatch just announced a native format for tracking custom metrics through CloudWatch Logs: https://aws.amazon.com/about-aws/whats-new/2019/11/amazon-cloudwatch-launches-embedded-metric-format/

Maybe it's time to let you choose how you want to record those custom metrics from our libraries - i.e. the http client

@benheymink
Copy link
Contributor

@theburningmonk This would make a great additional to the power tools, is it still on the radar?

@benheymink
Copy link
Contributor

Additionally middy version 2.x provides an implementation of a middleware for cloudwatch-metrics (Embedded metric format), link: https://github.com/middyjs/middy/tree/main/packages/cloudwatch-metrics But given that middy version 1.x is incompatible with middy version 2.x , the middleware for cloudwatch-metrics (Embedded metric format) cannot be used together with dazn-power-tools. I have writtten some test cases , here: https://github.com/niko-achilles/cloudwatchMetrics-lambda-power-tools that proves this fact and came to conclusion that i needed to create a middy version 1.x cloudwatch-metrics midddleware (Embedded metric format) in order to use it with dazn-power-tools. That also mean that for the libraries - i.e http client , in order to support cloudwatch-metrics (Embedded metric format) a re-implementation is needed .

Any plans about supporting cloudwatch-metrics (Embedded metric format) as middy middleware with dazn-power-tools ?

These power tools now support middy 2.0, so https://github.com/middyjs/middy/tree/main/packages/cloudwatch-metrics probably solves this need now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants