Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart? #246

Closed
mtiller opened this issue Feb 2, 2022 · 7 comments
Closed

Helm chart? #246

mtiller opened this issue Feb 2, 2022 · 7 comments

Comments

@mtiller
Copy link

mtiller commented Feb 2, 2022

I see that there is a Kubernetes manifest provided for Meli, but no helm chart. Helm is a little bit more convenient and makes customization a bit easer (via the values.yaml file). Are there any plans to provide an official helm chart? I could contribute mine if anybody is interested. I don't claim it is perfect, but as I mention in #233, it does provide a way of handling branches with SSL (if you are using cert-manager).

@titansmc
Copy link

titansmc commented Feb 2, 2022

I would be happy to see your helm chart if you don't mind.

@mtiller
Copy link
Author

mtiller commented Feb 2, 2022

Happy to share it. I need to do a bit more work to make it generic. At a minimum, I guess I can submit a PR and you'll be able to see it there. I'd just like to know that the PR has some chance of getting accepted. But since you are interested, I'll go ahead and do it and hopefully it will get included. Ideally, it would be good if it got published in a chart registry somewhere as well.

@titansmc
Copy link

titansmc commented Feb 2, 2022

I have asked in the discord group about the project and the developer mentioned that they don't have time to continue with the project anymore....I hope this is not the case!

@gempain
Copy link
Contributor

gempain commented Feb 2, 2022

@mtiller I have to admit my knowledge of helm and kubernetes varies from very limited to non existent. I'd be happy to accept a PR for this thought I have no real way to verify it except than making sure it works for your guys.

Regarding the fact that we don't have time anymore, my colleague @pimartin replied on Discord but I wanted to clarify things. I know you have offered to pay for support, and while this is a really awesome proposition, it's financially difficult to work on this project a lot when very few users are paying for it, and the day we accept paid support, we'll have to be there no matter what as we'll be contractually tied, while free usage gives us the freedom to develop when we can. We both have a full time job, and lots of things to work on, so finding time for Meli is hard. I look at issues and try to respond promptly but it's not always easy. That said, I'm happy to see contributions though. We're here to assist, but I'd love to see the community get involved more. It's easy to ask for features and open issues but we work on this in our free time and Meli is free of charge. We have the same problem as any open source software on Github: most people use it for free and want features while no one really wants to contribute or pay (I know @titansmc it's not your case).

@mtiller
Copy link
Author

mtiller commented Feb 2, 2022

@gempain as I told @titansmc, I'll create a PR and you can choose to accept it or not. Worst case, it just sits in a PR.

I think you are confusing me with someone else though. I'm not on Discord and never made any mention about support. I totally understand this is open source which is why in all my issues (except 1 I think), I offered to submit a pull request. I'm happy to make the contribution. My only concern is when those requests will ultimately find their way into the "official" Docker image. I can easily build the images myself and deploy them in my own container registry, so it isn't a huge problem though.

@gempain
Copy link
Contributor

gempain commented Feb 2, 2022

Not you @mtiller, but @titansmc did say he asked us on Discord, and we had a user on Discord ask whether the project was still alive and mentioning he was willing to pay for support, to which my colleague @pimartin responded that we were a bit busy elsewhere for the moment.

@mtiller you're actually one of the top contributors in terms of PRs and issues now: cross checking and responding to multiple issues, it's really awesome, thanks so much for this.

Also note that i'm super happy to accept PRs 😄

mt35-rs added a commit to mtiller/meli that referenced this issue Feb 2, 2022
This commit includes a helm chart or Meli.  I created it based on the
k8s manifest contributed by @Berndinox.  Hopefully that `values.yaml`
file I provided sufficiently explains the various knobs to turn.  One
potential area of improvement would be allowing existing PVCs to
be used.

Note that this includes the feature I mentioned in getmeli#233 but which
also applies to getmeli#238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
_for branch host names_.

Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software.  I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented.  If there _is_ a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.

Not that the `values.yaml` file include the image and tag.  This
can be customized to run a custom Meli image instead of the
official Docker hub image.

This closes getmeli#246.
mt35-rs added a commit to mtiller/meli that referenced this issue Feb 2, 2022
This commit includes a helm chart or Meli.  I created it based on the
k8s manifest contributed by @Berndinox.  Hopefully that `values.yaml`
file I provided sufficiently explains the various knobs to turn.  One
potential area of improvement would be allowing existing PVCs to
be used.

Note that this includes the feature I mentioned in getmeli#233 but which
also applies to getmeli#238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
_for branch host names_.

Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software.  I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented.  If there _is_ a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.

Not that the `values.yaml` file include the image and tag.  This
can be customized to run a custom Meli image instead of the
official Docker hub image.

This closes getmeli#246.
@mtiller
Copy link
Author

mtiller commented Feb 2, 2022

OK, I submitted a PR. So @titansmc, let me know if you have any issues. I did a basic install myself and it worked. I fully admit we could add more "knobs" to it and somebody else may very well need to in order for it to fit into their conventions/infrastructure/process.

I'll close this since I'm not expecting anybody else to do anything here.

@mtiller mtiller closed this as completed Feb 2, 2022
gempain pushed a commit that referenced this issue Feb 2, 2022
This commit includes a helm chart or Meli.  I created it based on the
k8s manifest contributed by @Berndinox.  Hopefully that `values.yaml`
file I provided sufficiently explains the various knobs to turn.  One
potential area of improvement would be allowing existing PVCs to
be used.

Note that this includes the feature I mentioned in #233 but which
also applies to #238 which is the ability to explicitly list all sites
so that the ingress configuration can fetch SSL certificates
_for branch host names_.

Ideally, this helm chart would be packaged up and shared...somewhere.
I'm actually not that well versed in how to host helm charts for
open source software.  I know there used to be a public registry
hosted by Google but then they withdrew support and the
landscape got very fragmented.  If there _is_ a place to host such
a chart, it would be good to publish this there so that an ordinary
helm installation could reference it.

Not that the `values.yaml` file include the image and tag.  This
can be customized to run a custom Meli image instead of the
official Docker hub image.

This closes #246.

Co-authored-by: Michael Tiller <michael.tiller@ricardo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants