Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable email credentials per site #229

Open
tanc opened this issue May 20, 2021 · 3 comments
Open

Configurable email credentials per site #229

tanc opened this issue May 20, 2021 · 3 comments
Labels
feature New feature

Comments

@tanc
Copy link
Contributor

tanc commented May 20, 2021

I'm maybe not understanding exactly how the forms functionality works, but it seems like sending email is restricted to a single mail account, the one set up that Meli uses for sending admin emails.

With potentially many sites/domains on a single Meli instance it would be useful to allow them to send mail through their choice of SMTP server.

It would be handy to be able to configure a site's forms to use specific mail host and credentials rather than it all getting piped through MELI_MAIL_HOST

@gempain
Copy link
Contributor

gempain commented May 20, 2021

This makes sense. We'd need to add a form to the site's setting page, and then load email config dynamically.

@gempain gempain added the feature New feature label May 20, 2021
@tanc
Copy link
Contributor Author

tanc commented May 20, 2021

Would it make sense to extend the existing 'forms' form to include the host and credentials field? That way when using the API to send the email the credentials can be dynamically checked and maybe fall back to the Meli defaults.

@gempain
Copy link
Contributor

gempain commented May 20, 2021

Forget what I said. As you say, we just need to extend the "forms" form (weird to say haha) and can fallback to the defaults when that info is not given. We will need to refactor a bit the email logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants