Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable encryption of the sns topic created by lift construct #323

Open
ghost opened this issue Apr 24, 2023 · 1 comment
Open

Enable encryption of the sns topic created by lift construct #323

ghost opened this issue Apr 24, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 24, 2023

Hi,

While using the lift construct to create sqs queues and worker lambdas, an sns topic is created when alarm is specified. Could you please have serverside encryption enabled for this sns topic?

@fredericbarthelet
Copy link
Collaborator

Hi @alanjoseuk and thanks for requesting this improvement.
As of today, you can rely on the extension feature to enable SSE on the SNS topic. Here is an exemple service file definition to achieve this:

constructs:
    my-queue:
        type: queue
        worker:
            handler: src/worker.handler
        alarm: alerting@mycompany.com
        extensions:
            alarm:
                Properties:
                    KmsMasterKeyId: "myKmsKeyId"

There is some dedicated configuration existing on the Queue construct to provide your own KMS key without relying on extensions for the SQS queue itself (see https://github.com/getlift/lift/blob/master/docs/queue.md#encryption). When a user specify SSE with a customer-owned KMS key, this configuration could be used as well for SNS if any alarm is configured as well. WDYT ? Would you be up to draft a PR to implement such functionality ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant