Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue :send should support --body-file as well as --body #314

Open
tomchiverton opened this issue Mar 6, 2023 · 5 comments
Open

Queue :send should support --body-file as well as --body #314

tomchiverton opened this issue Mar 6, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@tomchiverton
Copy link

Start from the Use-case

SQS function bodies can be complicated, and managing multiple different ones across a team is hard work when all you have is a shell history.

Example Config

n/a

Implementation Idea

serverless some-queue:send --stage QA --group-id=test --body-file tests/send-invalid-to-some-queue.json

@tomchiverton tomchiverton added the enhancement New feature or request label Mar 6, 2023
@mnapoli
Copy link
Member

mnapoli commented Mar 6, 2023

Sounds like a good improvement to have, a PR would be welcome 👍

@tomchiverton
Copy link
Author

tomchiverton commented Mar 6, 2023

If I had any idea where the command line parser was, I could probably take an initial stab.

@tomchiverton
Copy link
Author

@mnapoli
Copy link
Member

mnapoli commented Mar 6, 2023

We don't need a new command, but a new option. I think you should probably modify that line: https://github.com/getlift/lift/blob/master/src/constructs/aws/Queue.ts#L552

@tomchiverton
Copy link
Author

I'm also not familiar enough with the project to know how to set up a local version to test with. If this wasn't TypeScript (that needs a build step ?) I could just edit the file in my project's node_modules and see what happened.

So how do I work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants