Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid resources for kedro nodes with _ in the name #231

Open
szczeles opened this issue Apr 7, 2023 · 0 comments
Open

Invalid resources for kedro nodes with _ in the name #231

szczeles opened this issue Apr 7, 2023 · 0 comments

Comments

@szczeles
Copy link
Contributor

szczeles commented Apr 7, 2023

Pipeline generator sanitizes the node name to be kubeflow-compatible, but when it comes to details selection (like resources, tolerations), it doesn't follow the same logic, it purely checks for op name: https://github.com/getindata/kedro-kubeflow/blob/0.7.4/kedro_kubeflow/generators/utils.py#L177

Therefore, with the Kedro node named some_node, and specific resources for some_node, it uses defaults instead. We should check for uncleaned name in the config file to cover cases like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant