Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to LabVIEW #61

Open
felipefoz opened this issue Jun 22, 2021 · 5 comments
Open

Port to LabVIEW #61

felipefoz opened this issue Jun 22, 2021 · 5 comments

Comments

@felipefoz
Copy link

Hey,
I want to port this code to LabVIEW.
I have already a working code and passing all tests in my machine.
Following the instructions I believe I should open an issue before doing the fork, right?
Waiting further instructions and possible discussion.
Regards,

@getify
Copy link
Owner

getify commented Jun 22, 2021

Great! Can you follow these instructions? https://github.com/getify/JSON.minify/blob/master/PORTING.md

@felipefoz
Copy link
Author

felipefoz commented Jun 22, 2021

Created pull request #62.
Let me know if I did something wrong so I can rework it.
Just by curiosity, do you know of any project like that for beautifier/prettier JSON?

@felipefoz
Copy link
Author

Hi, do you need any extra information to perform the pull request?

@getify
Copy link
Owner

getify commented Aug 8, 2021

I left it open because ideally I'd like to have any PR reviewed by someone who knows the language in question. Moreover, the nature of this language appears to be that you're not distributing a text source code that I (or anyone without LabVIEW) can actually look at. So it's hard for me to just accept the PR.

@felipefoz
Copy link
Author

felipefoz commented Aug 8, 2021

Ok, I understand it.
So, if someone volunteers to review the code, one can download the free IDE version from
LabVIEW Community Edition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants