Images module backward compatibility, upgrade help

[pensivedog]

I am trying to upgrade a Hyas site to use the latest Images module. After following the upgrade guide, builds fail with errors related to image module partial and shortcode calls. I have many articles using the old shortcode syntax, and many templates using the old partial syntax.

Is the only way to upgrade to manually change each article that uses the shortcode and layout template that calls the partial?

[pensivedog]

Turns out I was able to get builds working again by simply doing a find and replace in my template files:

partial "picture" to partial "picture.html"

and

"ctx" . to "page" .

[pensivedog]

Actually, the above only worked in dev. I'm still getting an error when running npm run build:

execute of template failed: template: partials/picture.html:202:10: executing "partials/picture.html" at <site>: can't evaluate field landscape in type bool

[h-enk]

Did you follow the Manual Setup guide?

Here's a minimum and maximum example of the picture partial.

Also, check out the full reference

[h-enk]

This should work though (when you place your image in assets/images:

{{ $image := resources.Get "images/vincent-van-zalinge-IicWDdQUfsQ-unsplash.jpg" }}
{{- partial "picture" (dict "page" . "src" $image) }}

[pensivedog]

Getting closer... I did find-replace in my layout templates and changed all {{ $image := .Page.Resources.GetMatch .Params.featured_image }} to {{ $image := resources.Get .Params.featured_image }}.

Now, I no longer get errors for the partial, but I am getting errors for the figure shortcode:

Error: error building site: "C:\mysite\content\articles\article-title\index.md:242:1": failed to render shortcode "figure": failed to process shortcode: "C:\mysite\node_modules\@hyas\images\layouts\shortcodes\figure.html:125:4": execute of template failed: template: shortcodes/figure.html:125:4: executing "shortcodes/figure.html" at <partial "figure.html" $ctx>: error calling partial: "C:\mysite\node_modules\@hyas\images\layouts\partials\figure.html:204:10": execute of template failed: template: partials/figure.html:204:10: executing "partials/figure.html" at <site>: can't evaluate field landscape in type bool

The shortcode is using an image in the same directory as the markdown file, and the syntax is exactly the same as in the docs:

{{< figure
  src="vincent-van-zalinge-e5VzJJDODbQ-unsplash.jpg"
  alt="A yellow and black bird sitting on top of a body of water"
  caption="A yellow and black bird sitting on top of a body of water. Photo by Vincent van Zalinge"
>}}

[h-enk]

This is how I did it for Doks: https://github.com/gethyas/doks-core/blob/main/layouts/blog/single.html#L11-L23

[pensivedog]

Thank you for the reply. It seems no matter what I do, I get the below error when running npm run build but not when running npm run dev:

Error: error building site: render: failed to render pages: render of "page" failed: execute of template failed: template: articles/single.html:22:15: executing "main" at <partial "picture" (dict "page" . "src" $image)>: error calling partial: "C:\mysite\node_modules\@hyas\images\layouts\partials\picture.html:202:10": execute of template failed: template: partials/picture.html:202:10: executing "partials/picture.html" at <site>: can't evaluate field landscape in type bool

[pensivedog]

Ok, I finally figured out what was causing this error. I had previously created a config param that turned off hyas images in dev in order to have faster build times. Removing this from config and references to it in my templates got rid of this error.